webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.cc - Issue 2535593002: RTC_[D]CHECK_op: Remove "u" suffix on integer constants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.cc

Issue 2535593002: RTC_[D]CHECK_op: Remove "u" suffix on integer constants (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.cc

index 69df03a000a4b2aa9a43b7065a22032a5a61efee..7f62e18c9bb6f92354e4c8ec01687f757a2928a3 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.cc

@@ -84,7 +84,7 @@ bool Fir::Create(uint8_t* packet,

size_t index_end = *index + BlockLength();

CreateHeader(kFeedbackMessageType, kPacketType, HeaderLength(), packet,

index);

- RTC_DCHECK_EQ(Psfb::media_ssrc(), 0u);

+ RTC_DCHECK_EQ(Psfb::media_ssrc(), 0);

CreateCommonFeedback(packet + *index);

*index += kCommonFeedbackLength;