Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/report_block.cc

Issue 2535593002: RTC_[D]CHECK_op: Remove "u" suffix on integer constants (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 extended_high_seq_num_ = ByteReader<uint32_t>::ReadBigEndian(&buffer[8]); 58 extended_high_seq_num_ = ByteReader<uint32_t>::ReadBigEndian(&buffer[8]);
59 jitter_ = ByteReader<uint32_t>::ReadBigEndian(&buffer[12]); 59 jitter_ = ByteReader<uint32_t>::ReadBigEndian(&buffer[12]);
60 last_sr_ = ByteReader<uint32_t>::ReadBigEndian(&buffer[16]); 60 last_sr_ = ByteReader<uint32_t>::ReadBigEndian(&buffer[16]);
61 delay_since_last_sr_ = ByteReader<uint32_t>::ReadBigEndian(&buffer[20]); 61 delay_since_last_sr_ = ByteReader<uint32_t>::ReadBigEndian(&buffer[20]);
62 62
63 return true; 63 return true;
64 } 64 }
65 65
66 void ReportBlock::Create(uint8_t* buffer) const { 66 void ReportBlock::Create(uint8_t* buffer) const {
67 // Runtime check should be done while setting cumulative_lost. 67 // Runtime check should be done while setting cumulative_lost.
68 RTC_DCHECK_LT(cumulative_lost(), (1u << 24)); // Have only 3 bytes for it. 68 RTC_DCHECK_LT(cumulative_lost(), (1 << 24)); // Have only 3 bytes for it.
69 69
70 ByteWriter<uint32_t>::WriteBigEndian(&buffer[0], source_ssrc()); 70 ByteWriter<uint32_t>::WriteBigEndian(&buffer[0], source_ssrc());
71 ByteWriter<uint8_t>::WriteBigEndian(&buffer[4], fraction_lost()); 71 ByteWriter<uint8_t>::WriteBigEndian(&buffer[4], fraction_lost());
72 ByteWriter<uint32_t, 3>::WriteBigEndian(&buffer[5], cumulative_lost()); 72 ByteWriter<uint32_t, 3>::WriteBigEndian(&buffer[5], cumulative_lost());
73 ByteWriter<uint32_t>::WriteBigEndian(&buffer[8], extended_high_seq_num()); 73 ByteWriter<uint32_t>::WriteBigEndian(&buffer[8], extended_high_seq_num());
74 ByteWriter<uint32_t>::WriteBigEndian(&buffer[12], jitter()); 74 ByteWriter<uint32_t>::WriteBigEndian(&buffer[12], jitter());
75 ByteWriter<uint32_t>::WriteBigEndian(&buffer[16], last_sr()); 75 ByteWriter<uint32_t>::WriteBigEndian(&buffer[16], last_sr());
76 ByteWriter<uint32_t>::WriteBigEndian(&buffer[20], delay_since_last_sr()); 76 ByteWriter<uint32_t>::WriteBigEndian(&buffer[20], delay_since_last_sr());
77 } 77 }
78 78
79 bool ReportBlock::SetCumulativeLost(uint32_t cumulative_lost) { 79 bool ReportBlock::SetCumulativeLost(uint32_t cumulative_lost) {
80 if (cumulative_lost >= (1u << 24)) { // Have only 3 bytes to store it. 80 if (cumulative_lost >= (1u << 24)) { // Have only 3 bytes to store it.
81 LOG(LS_WARNING) << "Cumulative lost is too big to fit into Report Block"; 81 LOG(LS_WARNING) << "Cumulative lost is too big to fit into Report Block";
82 return false; 82 return false;
83 } 83 }
84 cumulative_lost_ = cumulative_lost; 84 cumulative_lost_ = cumulative_lost;
85 return true; 85 return true;
86 } 86 }
87 87
88 } // namespace rtcp 88 } // namespace rtcp
89 } // namespace webrtc 89 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698