Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 2281513002: GN: Fix windows clang errors. Attempt 2. (Closed)

Created:
4 years, 3 months ago by ehmaldonado_webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Fix windows clang errors. Attempt 2. BUG=webrtc:6255 NOTRY=True Committed: https://crrev.com/d02fe4b53b9439a0a602479353a55e92c9bce40d Cr-Commit-Position: refs/heads/master@{#13942}

Patch Set 1 #

Patch Set 2 : Fixing errors. #

Patch Set 3 : Fix it :3 #

Patch Set 4 : Fix some more errors. #

Patch Set 5 : Fix some more errors. #

Patch Set 6 : Fix some more errors. #

Patch Set 7 : Fix some more errors. #

Patch Set 8 : Fix some more errors. #

Patch Set 9 : Fix some more errors. #

Patch Set 10 : Fix some more errors. #

Patch Set 11 : Fix some more errors. #

Patch Set 12 : THIS IS GREEN :D #

Patch Set 13 : Starting to clean up. #

Patch Set 14 : This might be it. #

Patch Set 15 : Nope #

Patch Set 16 : Crossed fingers. #

Patch Set 17 : Oh come on. #

Patch Set 18 : Revert mb_config.pyl. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -93 lines) Patch
M third_party/winsdk_samples/BUILD.gn View 1 2 2 chunks +27 lines, -21 lines 0 comments Download
M webrtc/api/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +6 lines, -1 line 0 comments Download
M webrtc/base/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 10 chunks +43 lines, -18 lines 0 comments Download
M webrtc/examples/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 3 chunks +16 lines, -8 lines 0 comments Download
M webrtc/media/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +6 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 2 chunks +11 lines, -7 lines 0 comments Download
M webrtc/modules/audio_device/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +31 lines, -23 lines 0 comments Download
M webrtc/modules/video_capture/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +20 lines, -11 lines 0 comments Download
M webrtc/stats/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/system_wrappers/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
kjellander_webrtc
*phew* You're demonstrating great patience with this CL. lgtm!
4 years, 3 months ago (2016-08-26 14:02:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2281513002/450001
4 years, 3 months ago (2016-08-26 14:04:17 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7753)
4 years, 3 months ago (2016-08-26 14:14:44 UTC) #12
ehmaldonado_webrtc
hbos/hta: Please review/lgtm webrtc/stats/BUILD.gn thanks :)
4 years, 3 months ago (2016-08-26 14:21:14 UTC) #14
kjellander_webrtc
On 2016/08/26 14:21:14, ehmaldonado_webrtc wrote: > hbos/hta: Please review/lgtm > > webrtc/stats/BUILD.gn > > thanks ...
4 years, 3 months ago (2016-08-26 20:23:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2281513002/450001
4 years, 3 months ago (2016-08-26 20:23:48 UTC) #17
commit-bot: I haz the power
Committed patchset #18 (id:450001)
4 years, 3 months ago (2016-08-26 20:31:29 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 20:31:40 UTC) #20
Message was sent while issue was closed.
Patchset 18 (id:??) landed as
https://crrev.com/d02fe4b53b9439a0a602479353a55e92c9bce40d
Cr-Commit-Position: refs/heads/master@{#13942}

Powered by Google App Engine
This is Rietveld 408576698