Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Side by Side Diff: webrtc/modules/audio_coding/BUILD.gn

Issue 2281513002: GN: Fix windows clang errors. Attempt 2. (Closed)
Patch Set: Revert mb_config.pyl. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/BUILD.gn ('k') | webrtc/modules/audio_device/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("../../build/webrtc.gni") 9 import("../../build/webrtc.gni")
10 import("audio_coding.gni") 10 import("audio_coding.gni")
(...skipping 1519 matching lines...) Expand 10 before | Expand all | Expand 10 after
1530 ] 1530 ]
1531 1531
1532 if (is_win) { 1532 if (is_win) {
1533 cflags = [ 1533 cflags = [
1534 # Disable warnings to enable Win64 build, issue 1323. 1534 # Disable warnings to enable Win64 build, issue 1323.
1535 "/wd4267", # size_t to int truncation 1535 "/wd4267", # size_t to int truncation
1536 ] 1536 ]
1537 } 1537 }
1538 } 1538 }
1539 1539
1540 config("isac_test_warnings_config") {
1541 if (is_win && is_clang) {
1542 cflags = [
1543 # Disable warnings failing when compiling with Clang on Windows.
1544 # https://bugs.chromium.org/p/webrtc/issues/detail?id=5366
1545 "-Wno-format",
1546 ]
1547 }
1548 }
1549
1540 executable("isac_test") { 1550 executable("isac_test") {
1541 testonly = true 1551 testonly = true
1542 1552
1543 sources = [ 1553 sources = [
1544 "codecs/isac/main/test/simpleKenny.c", 1554 "codecs/isac/main/test/simpleKenny.c",
1545 "codecs/isac/main/util/utility.c", 1555 "codecs/isac/main/util/utility.c",
1546 ] 1556 ]
1547 1557
1548 include_dirs = [ 1558 include_dirs = [
1549 "codecs/isac/main/include", 1559 "codecs/isac/main/include",
1550 "codecs/isac/main/test", 1560 "codecs/isac/main/test",
1551 "codecs/isac/main/util", 1561 "codecs/isac/main/util",
1552 ] 1562 ]
1553 1563
1554 deps = [ 1564 deps = [
1555 ":isac", 1565 ":isac",
1556 "../../base:rtc_base_approved", 1566 "../../base:rtc_base_approved",
1557 "//build/config/sanitizers:deps", 1567 "//build/config/sanitizers:deps",
1558 ] 1568 ]
1559 1569
1560 if (is_win && is_clang) { 1570 configs += [ ":isac_test_warnings_config" ]
1561 cflags = [
1562 # Disable warnings failing when compiling with Clang on Windows.
1563 # https://bugs.chromium.org/p/webrtc/issues/detail?id=5366
1564 "-Wno-format",
1565 ]
1566 }
1567 } 1571 }
1568 1572
1569 executable("g711_test") { 1573 executable("g711_test") {
1570 testonly = true 1574 testonly = true
1571 1575
1572 sources = [ 1576 sources = [
1573 "codecs/g711/test/testG711.cc", 1577 "codecs/g711/test/testG711.cc",
1574 ] 1578 ]
1575 1579
1576 configs += [ "../..:common_config" ] 1580 configs += [ "../..:common_config" ]
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
1616 "//testing/gtest", 1620 "//testing/gtest",
1617 ] 1621 ]
1618 1622
1619 if (is_clang) { 1623 if (is_clang) {
1620 # Suppress warnings from Chrome's Clang plugins. 1624 # Suppress warnings from Chrome's Clang plugins.
1621 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. 1625 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
1622 configs -= [ "//build/config/clang:find_bad_constructs" ] 1626 configs -= [ "//build/config/clang:find_bad_constructs" ]
1623 } 1627 }
1624 } 1628 }
1625 } 1629 }
OLDNEW
« no previous file with comments | « webrtc/media/BUILD.gn ('k') | webrtc/modules/audio_device/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698