Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: webrtc/modules/video_capture/BUILD.gn

Issue 2281513002: GN: Fix windows clang errors. Attempt 2. (Closed)
Patch Set: Revert mb_config.pyl. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/audio_device/BUILD.gn ('k') | webrtc/stats/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/video_capture/BUILD.gn
diff --git a/webrtc/modules/video_capture/BUILD.gn b/webrtc/modules/video_capture/BUILD.gn
index 8edac8941a1afcc45cfcd2919a6a4077db0ec175..0875ed8ea60a85d832bbc6cb1cf10c99d815e5dc 100644
--- a/webrtc/modules/video_capture/BUILD.gn
+++ b/webrtc/modules/video_capture/BUILD.gn
@@ -76,7 +76,27 @@ if (!build_with_chromium) {
}
}
+ config("video_capture_internal_impl_warnings_config") {
+ if (is_win && is_clang) {
+ cflags = [
+ "-Wno-comment",
+ "-Wno-ignored-attributes",
+
+ # See https://bugs.chromium.org/p/webrtc/issues/detail?id=6269
+ # for -Wno-ignored-qualifiers
+ "-Wno-ignored-qualifiers",
+ "-Wno-microsoft-extra-qualification",
+ "-Wno-missing-braces",
+ "-Wno-overloaded-virtual",
+ "-Wno-reorder",
+ "-Wno-writable-strings",
+ ]
+ }
+ }
+
source_set("video_capture_internal_impl") {
+ configs += [ ":video_capture_internal_impl_warnings_config" ]
+
deps = [
":video_capture_module",
"../../system_wrappers",
@@ -136,17 +156,6 @@ if (!build_with_chromium) {
deps += [ "//third_party/winsdk_samples" ]
}
- if (is_win && is_clang) {
- cflags = [
- "-Wno-comment",
- "-Wno-ignored-attributes",
- "-Wno-microsoft-extra-qualification",
- "-Wno-missing-braces",
- "-Wno-overloaded-virtual",
- "-Wno-reorder",
- "-Wno-writable-strings",
- ]
- }
if (is_ios) {
sources = [
"ios/device_info_ios.h",
« no previous file with comments | « webrtc/modules/audio_device/BUILD.gn ('k') | webrtc/stats/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698