Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: webrtc/modules/video_capture/BUILD.gn

Issue 2281513002: GN: Fix windows clang errors. Attempt 2. (Closed)
Patch Set: Revert mb_config.pyl. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/audio_device/BUILD.gn ('k') | webrtc/stats/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("../../build/webrtc.gni") 9 import("../../build/webrtc.gni")
10 import("//testing/test.gni") 10 import("//testing/test.gni")
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 config("video_capture_internal_impl_config") { 69 config("video_capture_internal_impl_config") {
70 if (is_ios) { 70 if (is_ios) {
71 libs = [ 71 libs = [
72 "AVFoundation.framework", 72 "AVFoundation.framework",
73 "CoreMedia.framework", 73 "CoreMedia.framework",
74 "CoreVideo.framework", 74 "CoreVideo.framework",
75 ] 75 ]
76 } 76 }
77 } 77 }
78 78
79 config("video_capture_internal_impl_warnings_config") {
80 if (is_win && is_clang) {
81 cflags = [
82 "-Wno-comment",
83 "-Wno-ignored-attributes",
84
85 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=6269
86 # for -Wno-ignored-qualifiers
87 "-Wno-ignored-qualifiers",
88 "-Wno-microsoft-extra-qualification",
89 "-Wno-missing-braces",
90 "-Wno-overloaded-virtual",
91 "-Wno-reorder",
92 "-Wno-writable-strings",
93 ]
94 }
95 }
96
79 source_set("video_capture_internal_impl") { 97 source_set("video_capture_internal_impl") {
98 configs += [ ":video_capture_internal_impl_warnings_config" ]
99
80 deps = [ 100 deps = [
81 ":video_capture_module", 101 ":video_capture_module",
82 "../../system_wrappers", 102 "../../system_wrappers",
83 ] 103 ]
84 104
85 if (is_linux) { 105 if (is_linux) {
86 sources = [ 106 sources = [
87 "linux/device_info_linux.cc", 107 "linux/device_info_linux.cc",
88 "linux/device_info_linux.h", 108 "linux/device_info_linux.h",
89 "linux/video_capture_linux.cc", 109 "linux/video_capture_linux.cc",
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 "windows/video_capture_ds.h", 149 "windows/video_capture_ds.h",
130 "windows/video_capture_factory_windows.cc", 150 "windows/video_capture_factory_windows.cc",
131 "windows/video_capture_mf.cc", 151 "windows/video_capture_mf.cc",
132 "windows/video_capture_mf.h", 152 "windows/video_capture_mf.h",
133 ] 153 ]
134 154
135 libs = [ "Strmiids.lib" ] 155 libs = [ "Strmiids.lib" ]
136 156
137 deps += [ "//third_party/winsdk_samples" ] 157 deps += [ "//third_party/winsdk_samples" ]
138 } 158 }
139 if (is_win && is_clang) {
140 cflags = [
141 "-Wno-comment",
142 "-Wno-ignored-attributes",
143 "-Wno-microsoft-extra-qualification",
144 "-Wno-missing-braces",
145 "-Wno-overloaded-virtual",
146 "-Wno-reorder",
147 "-Wno-writable-strings",
148 ]
149 }
150 if (is_ios) { 159 if (is_ios) {
151 sources = [ 160 sources = [
152 "ios/device_info_ios.h", 161 "ios/device_info_ios.h",
153 "ios/device_info_ios.mm", 162 "ios/device_info_ios.mm",
154 "ios/device_info_ios_objc.h", 163 "ios/device_info_ios_objc.h",
155 "ios/device_info_ios_objc.mm", 164 "ios/device_info_ios_objc.mm",
156 "ios/rtc_video_capture_ios_objc.h", 165 "ios/rtc_video_capture_ios_objc.h",
157 "ios/rtc_video_capture_ios_objc.mm", 166 "ios/rtc_video_capture_ios_objc.mm",
158 "ios/video_capture_ios.h", 167 "ios/video_capture_ios.h",
159 "ios/video_capture_ios.mm", 168 "ios/video_capture_ios.mm",
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 } 232 }
224 233
225 if (is_clang) { 234 if (is_clang) {
226 # Suppress warnings from Chrome's Clang plugins. 235 # Suppress warnings from Chrome's Clang plugins.
227 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. 236 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
228 configs -= [ "//build/config/clang:find_bad_constructs" ] 237 configs -= [ "//build/config/clang:find_bad_constructs" ]
229 } 238 }
230 } 239 }
231 } 240 }
232 } 241 }
OLDNEW
« no previous file with comments | « webrtc/modules/audio_device/BUILD.gn ('k') | webrtc/stats/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698