GN: Fix windows clang errors. Attempt 2.

third_party/winsdk_samples/BUILD.gn

Index: third_party/winsdk_samples/BUILD.gn
diff --git a/third_party/winsdk_samples/BUILD.gn b/third_party/winsdk_samples/BUILD.gn
index 82d12332e3f6852021aeff930c342d89d1cff61b..114f31ff89aeef3c43c8af26ee40c9fc09c98a48 100644
--- a/third_party/winsdk_samples/BUILD.gn
+++ b/third_party/winsdk_samples/BUILD.gn
@@ -13,6 +13,29 @@ if (is_win) {
     include_dirs = [ baseclasses_dir ]
   }
 
+  config("winsdk_samples_warnings_config") {
+    if (is_win && is_clang) {
+      cflags = [
+        # Disable warnings failing when compiling with Clang on Windows.
+        # https://bugs.chromium.org/p/webrtc/issues/detail?id=5366
+        "-Wno-comment",
+        "-Wno-delete-non-virtual-dtor",
+        "-Wno-ignored-attributes",
+        "-Wno-logical-op-parentheses",
+        "-Wno-non-pod-varargs",
+        "-Wno-microsoft-extra-qualification",
+        "-Wno-missing-braces",
+        "-Wno-overloaded-virtual",
+        "-Wno-parentheses",
+        "-Wno-reorder",
+        "-Wno-string-conversion",
+        "-Wno-tautological-constant-out-of-range-compare",
+        "-Wno-unused-private-field",
+        "-Wno-writable-strings",
+      ]
+    }
+  }
+
   static_library("winsdk_samples") {
     sources = [
       "$baseclasses_dir/amextra.cpp",
@@ -84,26 +107,9 @@ if (is_win) {
       "//build/config/compiler:chromium_code",
       "//build/config/win:nominmax",
     ]
-    configs += [ "//build/config/compiler:no_chromium_code" ]
-    if (is_win && is_clang) {
-      cflags += [
-        # Disable warnings failing when compiling with Clang on Windows.
-        # https://bugs.chromium.org/p/webrtc/issues/detail?id=5366
-        "-Wno-comment",
-        "-Wno-delete-non-virtual-dtor",
-        "-Wno-ignored-attributes",
-        "-Wno-logical-op-parentheses",
-        "-Wno-non-pod-varargs",
-        "-Wno-microsoft-extra-qualification",
-        "-Wno-missing-braces",
-        "-Wno-overloaded-virtual",
-        "-Wno-parentheses",
-        "-Wno-reorder",
-        "-Wno-string-conversion",
-        "-Wno-tautological-constant-out-of-range-compare",
-        "-Wno-unused-private-field",
-        "-Wno-writable-strings",
-      ]
-    }
+    configs += [
+      "//build/config/compiler:no_chromium_code",
+      ":winsdk_samples_warnings_config",
+    ]
   }
 }