Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: webrtc/test/BUILD.gn

Issue 2281513002: GN: Fix windows clang errors. Attempt 2. (Closed)
Patch Set: Revert mb_config.pyl. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/system_wrappers/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/test/BUILD.gn
diff --git a/webrtc/test/BUILD.gn b/webrtc/test/BUILD.gn
index 2487976094ebd568ee533d2974780702b2a347d3..9fd7d1af694668491b660c1077fdd5092b4aee83 100644
--- a/webrtc/test/BUILD.gn
+++ b/webrtc/test/BUILD.gn
@@ -33,13 +33,17 @@ config("channel_transport_warnings_config") {
cflags = [ "/wd4302" ] # cast truncation
if (is_clang) {
- # GN orders flags on a target before flags from configs. The default config
- # adds -Wall, and this flag have to be after -Wall -- so they need to
- # come from a config and cannot be on the target directly.
+ # GN orders flags on a target before flags from configs. The default
+ # config adds -Wall, and this flag have to be after -Wall -- so they need
+ # to come from a config and cannot be on the target directly.
cflags += [
"-Wno-parentheses-equality",
"-Wno-reorder",
"-Wno-tautological-constant-out-of-range-compare",
+
+ # See https://bugs.chromium.org/p/webrtc/issues/detail?id=6268
+ # for -Wno-thread-safety-analysis
+ "-Wno-thread-safety-analysis",
"-Wno-unused-private-field",
]
}
« no previous file with comments | « webrtc/system_wrappers/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698