Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: webrtc/api/BUILD.gn

Issue 2281513002: GN: Fix windows clang errors. Attempt 2. (Closed)
Patch Set: Revert mb_config.pyl. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/winsdk_samples/BUILD.gn ('k') | webrtc/base/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("../build/webrtc.gni") 9 import("../build/webrtc.gni")
10 import("//testing/test.gni") 10 import("//testing/test.gni")
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 } 294 }
295 295
296 if (rtc_include_tests) { 296 if (rtc_include_tests) {
297 config("peerconnection_unittests_config") { 297 config("peerconnection_unittests_config") {
298 # The warnings below are enabled by default. Since GN orders compiler flags 298 # The warnings below are enabled by default. Since GN orders compiler flags
299 # for a target before flags from configs, the only way to disable such 299 # for a target before flags from configs, the only way to disable such
300 # warnings is by having them in a separate config, loaded from the target. 300 # warnings is by having them in a separate config, loaded from the target.
301 # TODO(kjellander): Make the code compile without disabling these flags. 301 # TODO(kjellander): Make the code compile without disabling these flags.
302 # See https://bugs.webrtc.org/3307. 302 # See https://bugs.webrtc.org/3307.
303 if (is_clang && is_win) { 303 if (is_clang && is_win) {
304 cflags = [ "-Wno-unused-function" ] 304 cflags = [
305 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=6267
306 # for -Wno-sign-compare
307 "-Wno-sign-compare",
308 "-Wno-unused-function",
309 ]
305 } 310 }
306 311
307 if (!is_win) { 312 if (!is_win) {
308 cflags = [ "-Wno-sign-compare" ] 313 cflags = [ "-Wno-sign-compare" ]
309 cflags_cc = [ "-Wno-overloaded-virtual" ] 314 cflags_cc = [ "-Wno-overloaded-virtual" ]
310 } 315 }
311 } 316 }
312 317
313 test("peerconnection_unittests") { 318 test("peerconnection_unittests") {
314 testonly = true 319 testonly = true
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
439 444
440 shared_libraries = [ ":libjingle_peerconnection_so" ] 445 shared_libraries = [ ":libjingle_peerconnection_so" ]
441 } 446 }
442 447
443 android_resources("libjingle_peerconnection_android_unittest_resources") { 448 android_resources("libjingle_peerconnection_android_unittest_resources") {
444 resource_dirs = [ "androidtests/res" ] 449 resource_dirs = [ "androidtests/res" ]
445 custom_package = "org.webrtc" 450 custom_package = "org.webrtc"
446 } 451 }
447 } 452 }
448 } 453 }
OLDNEW
« no previous file with comments | « third_party/winsdk_samples/BUILD.gn ('k') | webrtc/base/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698