Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2074423002: Fix some sign-compare warnings in webrtc/api. (Closed)

Created:
4 years, 6 months ago by kjellander_webrtc
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix some sign-compare warnings in webrtc/api. The disabling of the warnings doesn't seem to work when Chromium is using our targets (https://codereview.chromium.org/2022833002) so better fix them. BUG=webrtc:4256, webrtc:3307 NOTRY=True Committed: https://crrev.com/3e33bfeb6d4a7b9e14ce856e849f5e0367689e09 Cr-Commit-Position: refs/heads/master@{#13217}

Patch Set 1 #

Patch Set 2 : Fixed Android #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -34 lines) Patch
M webrtc/api/BUILD.gn View 1 2 chunks +2 lines, -9 lines 0 comments Download
M webrtc/api/api.gyp View 2 chunks +0 lines, -22 lines 0 comments Download
M webrtc/api/datachannel.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/api/videocapturertracksource.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/webrtcsdp.cc View 1 chunk +2 lines, -1 line 2 comments Download

Messages

Total messages: 11 (4 generated)
kjellander_webrtc
4 years, 6 months ago (2016-06-20 10:00:55 UTC) #2
kjellander_webrtc
+henrika since perkj is OOO today.
4 years, 6 months ago (2016-06-20 13:52:06 UTC) #4
henrika_webrtc
LGTM with nit comment https://codereview.webrtc.org/2074423002/diff/20001/webrtc/api/webrtcsdp.cc File webrtc/api/webrtcsdp.cc (right): https://codereview.webrtc.org/2074423002/diff/20001/webrtc/api/webrtcsdp.cc#newcode2190 webrtc/api/webrtcsdp.cc:2190: int payload_type = *it; can't ...
4 years, 6 months ago (2016-06-20 13:55:55 UTC) #5
kjellander_webrtc
https://codereview.webrtc.org/2074423002/diff/20001/webrtc/api/webrtcsdp.cc File webrtc/api/webrtcsdp.cc (right): https://codereview.webrtc.org/2074423002/diff/20001/webrtc/api/webrtcsdp.cc#newcode2190 webrtc/api/webrtcsdp.cc:2190: int payload_type = *it; On 2016/06/20 13:55:55, henrika_webrtc wrote: ...
4 years, 6 months ago (2016-06-20 14:02:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074423002/20001
4 years, 6 months ago (2016-06-20 14:02:34 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-20 14:04:14 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 14:04:29 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e33bfeb6d4a7b9e14ce856e849f5e0367689e09
Cr-Commit-Position: refs/heads/master@{#13217}

Powered by Google App Engine
This is Rietveld 408576698