Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: webrtc/api/webrtcsdp.cc

Issue 2074423002: Fix some sign-compare warnings in webrtc/api. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixed Android Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/videocapturertracksource.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/webrtcsdp.cc
diff --git a/webrtc/api/webrtcsdp.cc b/webrtc/api/webrtcsdp.cc
index b2e75a21cbf911fc38273f43f1208f64357ea7c1..0b8d6f6a3d3fc28e4c4e6ba7d8de9655cc5234dc 100644
--- a/webrtc/api/webrtcsdp.cc
+++ b/webrtc/api/webrtcsdp.cc
@@ -2190,7 +2190,8 @@ void MaybeCreateStaticPayloadAudioCodecs(
int payload_type = *it;
henrika_webrtc 2016/06/20 13:55:55 can't you do size_t payload_type = *it here in
kjellander_webrtc 2016/06/20 14:02:26 I tried, but line 2192 checks if it's >=0 so it se
if (!media_desc->HasCodec(payload_type) &&
payload_type >= 0 &&
- payload_type < arraysize(kStaticPayloadAudioCodecs)) {
+ static_cast<uint32_t>(payload_type) <
+ arraysize(kStaticPayloadAudioCodecs)) {
std::string encoding_name = kStaticPayloadAudioCodecs[payload_type].name;
int clock_rate = kStaticPayloadAudioCodecs[payload_type].clockrate;
size_t channels = kStaticPayloadAudioCodecs[payload_type].channels;
« no previous file with comments | « webrtc/api/videocapturertracksource.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698