Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1646)

Unified Diff: webrtc/api/BUILD.gn

Issue 2074423002: Fix some sign-compare warnings in webrtc/api. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixed Android Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/api.gyp » ('j') | webrtc/api/webrtcsdp.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/BUILD.gn
diff --git a/webrtc/api/BUILD.gn b/webrtc/api/BUILD.gn
index cb3066eae69a3b0a580e4658a14b6cf76044d799..442ecbff0c7f5ff0d0ec2f28d670327b3973a5e3 100644
--- a/webrtc/api/BUILD.gn
+++ b/webrtc/api/BUILD.gn
@@ -19,11 +19,8 @@ config("libjingle_peerconnection_warnings_config") {
# GN orders flags on a target before flags from configs. The default config
# adds these flags so to cancel them out they need to come from a config and
# cannot be on the target directly.
- if (!is_win) {
- cflags = [ "-Wno-sign-compare" ]
- if (!is_clang) {
- cflags += [ "-Wno-maybe-uninitialized" ] # Only exists for GCC.
- }
+ if (!is_win && !is_clang) {
+ cflags = [ "-Wno-maybe-uninitialized" ] # Only exists for GCC.
}
}
@@ -110,10 +107,6 @@ source_set("libjingle_peerconnection") {
configs -= [ "//build/config/clang:find_bad_constructs" ]
}
- if (is_win) {
- cflags += [ "/wd4389" ] # signed/unsigned mismatch.
- }
-
deps = [
"../call",
"../media",
« no previous file with comments | « no previous file | webrtc/api/api.gyp » ('j') | webrtc/api/webrtcsdp.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698