Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: webrtc/api/api.gyp

Issue 2074423002: Fix some sign-compare warnings in webrtc/api. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixed Android Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/api.gyp
diff --git a/webrtc/api/api.gyp b/webrtc/api/api.gyp
index f63e7e4b11a4a28e967eae0d78bafb3a0a657533..887492f24eb9e82e2e51f2abd577c73f12186be5 100644
--- a/webrtc/api/api.gyp
+++ b/webrtc/api/api.gyp
@@ -198,11 +198,6 @@
'webrtcsessiondescriptionfactory.cc',
'webrtcsessiondescriptionfactory.h',
],
- # TODO(kjellander): Make the code compile without disabling these flags.
- # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307
- 'cflags': [
- '-Wno-sign-compare',
- ],
'conditions': [
['clang==1', {
'cflags!': [
@@ -216,23 +211,6 @@
'-Wno-maybe-uninitialized', # Only exists for GCC.
],
}],
- ['OS=="win"', {
- # Disable warning for signed/unsigned mismatch.
- 'msvs_settings': {
- 'VCCLCompilerTool': {
- 'AdditionalOptions!': ['/we4389'],
- },
- },
- }],
- ['OS=="win" and clang==1', {
- 'msvs_settings': {
- 'VCCLCompilerTool': {
- 'AdditionalOptions': [
- '-Wno-sign-compare',
- ],
- },
- },
- }],
['use_quic==1', {
'dependencies': [
'<(DEPTH)/third_party/libquic/libquic.gyp:libquic',
« no previous file with comments | « webrtc/api/BUILD.gn ('k') | webrtc/api/datachannel.cc » ('j') | webrtc/api/webrtcsdp.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698