webrtc/api/datachannel.cc - Issue 2074423002: Fix some sign-compare warnings in webrtc/api.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/datachannel.cc

Issue 2074423002: Fix some sign-compare warnings in webrtc/api. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fixed Android Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/api/datachannel.cc

diff --git a/webrtc/api/datachannel.cc b/webrtc/api/datachannel.cc

index 5a18e6f1e8ac62e567980c48a475b4e52a58bdc9..3435fa50d5a26e7bbf7edfd911a70d6a37cef42c 100644

--- a/webrtc/api/datachannel.cc

+++ b/webrtc/api/datachannel.cc

@@ -384,7 +384,8 @@ void DataChannel::OnDataReceived(cricket::DataChannel* channel,

}

void DataChannel::OnStreamClosedRemotely(uint32_t sid) {

- if (data_channel_type_ == cricket::DCT_SCTP && sid == config_.id) {

+ if (data_channel_type_ == cricket::DCT_SCTP &&

+ sid == static_cast<uint32_t>(config_.id)) {

Close();

}