Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: webrtc/api/api.gyp

Issue 2074423002: Fix some sign-compare warnings in webrtc/api. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixed Android Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 { 9 {
10 'includes': [ '../build/common.gypi', ], 10 'includes': [ '../build/common.gypi', ],
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 'videotrack.h', 191 'videotrack.h',
192 'videotracksource.cc', 192 'videotracksource.cc',
193 'videotracksource.h', 193 'videotracksource.h',
194 'webrtcsdp.cc', 194 'webrtcsdp.cc',
195 'webrtcsdp.h', 195 'webrtcsdp.h',
196 'webrtcsession.cc', 196 'webrtcsession.cc',
197 'webrtcsession.h', 197 'webrtcsession.h',
198 'webrtcsessiondescriptionfactory.cc', 198 'webrtcsessiondescriptionfactory.cc',
199 'webrtcsessiondescriptionfactory.h', 199 'webrtcsessiondescriptionfactory.h',
200 ], 200 ],
201 # TODO(kjellander): Make the code compile without disabling these flags.
202 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307
203 'cflags': [
204 '-Wno-sign-compare',
205 ],
206 'conditions': [ 201 'conditions': [
207 ['clang==1', { 202 ['clang==1', {
208 'cflags!': [ 203 'cflags!': [
209 '-Wextra', 204 '-Wextra',
210 ], 205 ],
211 'xcode_settings': { 206 'xcode_settings': {
212 'WARNING_CFLAGS!': ['-Wextra'], 207 'WARNING_CFLAGS!': ['-Wextra'],
213 }, 208 },
214 }, { 209 }, {
215 'cflags': [ 210 'cflags': [
216 '-Wno-maybe-uninitialized', # Only exists for GCC. 211 '-Wno-maybe-uninitialized', # Only exists for GCC.
217 ], 212 ],
218 }], 213 }],
219 ['OS=="win"', {
220 # Disable warning for signed/unsigned mismatch.
221 'msvs_settings': {
222 'VCCLCompilerTool': {
223 'AdditionalOptions!': ['/we4389'],
224 },
225 },
226 }],
227 ['OS=="win" and clang==1', {
228 'msvs_settings': {
229 'VCCLCompilerTool': {
230 'AdditionalOptions': [
231 '-Wno-sign-compare',
232 ],
233 },
234 },
235 }],
236 ['use_quic==1', { 214 ['use_quic==1', {
237 'dependencies': [ 215 'dependencies': [
238 '<(DEPTH)/third_party/libquic/libquic.gyp:libquic', 216 '<(DEPTH)/third_party/libquic/libquic.gyp:libquic',
239 ], 217 ],
240 'sources': [ 218 'sources': [
241 'quicdatachannel.cc', 219 'quicdatachannel.cc',
242 'quicdatachannel.h', 220 'quicdatachannel.h',
243 'quicdatatransport.cc', 221 'quicdatatransport.cc',
244 'quicdatatransport.h', 222 'quicdatatransport.h',
245 ], 223 ],
246 'export_dependent_settings': [ 224 'export_dependent_settings': [
247 '<(DEPTH)/third_party/libquic/libquic.gyp:libquic', 225 '<(DEPTH)/third_party/libquic/libquic.gyp:libquic',
248 ], 226 ],
249 }], 227 }],
250 ], 228 ],
251 }, # target libjingle_peerconnection 229 }, # target libjingle_peerconnection
252 ], # targets 230 ], # targets
253 } 231 }
OLDNEW
« no previous file with comments | « webrtc/api/BUILD.gn ('k') | webrtc/api/datachannel.cc » ('j') | webrtc/api/webrtcsdp.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698