Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: webrtc/api/BUILD.gn

Issue 2074423002: Fix some sign-compare warnings in webrtc/api. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixed Android Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/api/api.gyp » ('j') | webrtc/api/webrtcsdp.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("../build/webrtc.gni") 9 import("../build/webrtc.gni")
10 import("//testing/test.gni") 10 import("//testing/test.gni")
11 11
12 group("api") { 12 group("api") {
13 deps = [ 13 deps = [
14 ":libjingle_peerconnection", 14 ":libjingle_peerconnection",
15 ] 15 ]
16 } 16 }
17 17
18 config("libjingle_peerconnection_warnings_config") { 18 config("libjingle_peerconnection_warnings_config") {
19 # GN orders flags on a target before flags from configs. The default config 19 # GN orders flags on a target before flags from configs. The default config
20 # adds these flags so to cancel them out they need to come from a config and 20 # adds these flags so to cancel them out they need to come from a config and
21 # cannot be on the target directly. 21 # cannot be on the target directly.
22 if (!is_win) { 22 if (!is_win && !is_clang) {
23 cflags = [ "-Wno-sign-compare" ] 23 cflags = [ "-Wno-maybe-uninitialized" ] # Only exists for GCC.
24 if (!is_clang) {
25 cflags += [ "-Wno-maybe-uninitialized" ] # Only exists for GCC.
26 }
27 } 24 }
28 } 25 }
29 26
30 source_set("libjingle_peerconnection") { 27 source_set("libjingle_peerconnection") {
31 cflags = [] 28 cflags = []
32 sources = [ 29 sources = [
33 "audiotrack.cc", 30 "audiotrack.cc",
34 "audiotrack.h", 31 "audiotrack.h",
35 "datachannel.cc", 32 "datachannel.cc",
36 "datachannel.h", 33 "datachannel.h",
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 "..:common_config", 100 "..:common_config",
104 ":libjingle_peerconnection_warnings_config", 101 ":libjingle_peerconnection_warnings_config",
105 ] 102 ]
106 public_configs = [ "..:common_inherited_config" ] 103 public_configs = [ "..:common_inherited_config" ]
107 104
108 if (is_clang) { 105 if (is_clang) {
109 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). 106 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
110 configs -= [ "//build/config/clang:find_bad_constructs" ] 107 configs -= [ "//build/config/clang:find_bad_constructs" ]
111 } 108 }
112 109
113 if (is_win) {
114 cflags += [ "/wd4389" ] # signed/unsigned mismatch.
115 }
116
117 deps = [ 110 deps = [
118 "../call", 111 "../call",
119 "../media", 112 "../media",
120 "../pc", 113 "../pc",
121 ] 114 ]
122 115
123 if (rtc_use_quic) { 116 if (rtc_use_quic) {
124 sources += [ 117 sources += [
125 "quicdatachannel.cc", 118 "quicdatachannel.cc",
126 "quicdatachannel.h", 119 "quicdatachannel.h",
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
320 "../pc:rtc_pc", 313 "../pc:rtc_pc",
321 "../system_wrappers:metrics_default", 314 "../system_wrappers:metrics_default",
322 "//testing/gmock", 315 "//testing/gmock",
323 ] 316 ]
324 317
325 if (is_android) { 318 if (is_android) {
326 deps += [ "//testing/android/native_test:native_test_support" ] 319 deps += [ "//testing/android/native_test:native_test_support" ]
327 } 320 }
328 } 321 }
329 } 322 }
OLDNEW
« no previous file with comments | « no previous file | webrtc/api/api.gyp » ('j') | webrtc/api/webrtcsdp.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698