Fix all -Wnon-virtual-dtor warnings.

Fix all -Wnon-virtual-dtor warnings.

This is needed to get the GN build going for several parts
of the code tree.

BUG=webrtc:3307
NOTRY=True
R=henrika@webrtc.org, nisse@webrtc.org

Committed: https://crrev.com/3fe372dbee7d3c9ba7a58fd87c8df2e85decd73a
Cr-Commit-Position: refs/heads/master@{#12693}

[kjellander_webrtc, 2016-04-29 12:44:55]

Patchset #1 (id:1) has been deleted

[kjellander_webrtc, 2016-04-29 12:45:02]

Patchset #1 (id:20001) has been deleted

[kjellander_webrtc, 2016-04-29 12:48:57]

Description was changed from

==========
Fix all -Wnon-virtual-dtor warnings.

This is needed to get the GN build going for several parts
of the code tree.

BUG=webrtc:3307
==========

to

==========
Fix all -Wnon-virtual-dtor warnings.

This is needed to get the GN build going for several parts
of the code tree.

BUG=webrtc:3307
NOTRY=True
==========

[kjellander_webrtc, 2016-04-29 12:48:57]

kjellander@webrtc.org changed reviewers:
+ henrika@webrtc.org, nisse@webrtc.org

[nisse-webrtc, 2016-05-02 07:00:36]

I'd like to understand what "= default" really means here. Have to ask some c++
person. Looks fine otherwise.

https://codereview.webrtc.org/1928653005/diff/40001/webrtc/media/base/codec.h
File webrtc/media/base/codec.h (right):

https://codereview.webrtc.org/1928653005/diff/40001/webrtc/media/base/codec.h...
webrtc/media/base/codec.h:76: virtual ~Codec();
Seems a bit odd to have virtual methods on something declared as a struct. But
not a problem in this cl.

[nisse-webrtc, 2016-05-02 11:38:27]

lgtm

[kjellander_webrtc, 2016-05-11 17:47:27]

ping henrika

[henrika_webrtc, 2016-05-12 05:44:22]

LGTM

[kjellander_webrtc, 2016-05-12 05:44:45]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2016-05-12 05:44:45]

The patchset sent to the CQ was uploaded after l-g-t-m from nisse@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1928653005/#ps60001 (title:
"Rebased")

[commit-bot: I haz the power, 2016-05-12 05:44:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1928653005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1928653005/60001

[commit-bot: I haz the power, 2016-05-12 05:55:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 05:55:47]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/5467)

[commit-bot: I haz the power, 2016-05-12 06:11:15]

Description was changed from

==========
Fix all -Wnon-virtual-dtor warnings.

This is needed to get the GN build going for several parts
of the code tree.

BUG=webrtc:3307
NOTRY=True
==========

to

==========
Fix all -Wnon-virtual-dtor warnings.

This is needed to get the GN build going for several parts
of the code tree.

BUG=webrtc:3307
NOTRY=True
R=henrika@webrtc.org, nisse@webrtc.org

Committed: https://crrev.com/3fe372dbee7d3c9ba7a58fd87c8df2e85decd73a
Cr-Commit-Position: refs/heads/master@{#12693}
==========

[kjellander_webrtc, 2016-05-12 06:11:16]

Description was changed from

==========
Fix all -Wnon-virtual-dtor warnings.

This is needed to get the GN build going for several parts
of the code tree.

BUG=webrtc:3307
NOTRY=True
R=henrika@webrtc.org, nisse@webrtc.org

Committed: https://crrev.com/3fe372dbee7d3c9ba7a58fd87c8df2e85decd73a
Cr-Commit-Position: refs/heads/master@{#12693}
==========

to

==========
Fix all -Wnon-virtual-dtor warnings.

This is needed to get the GN build going for several parts
of the code tree.

BUG=webrtc:3307
NOTRY=True
R=henrika@webrtc.org, nisse@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/3fe372dbee7d3c9ba7a58fd87...
==========

[commit-bot: I haz the power, 2016-05-12 06:11:16]

Patchset 2 (id:??) landed as
https://crrev.com/3fe372dbee7d3c9ba7a58fd87c8df2e85decd73a
Cr-Commit-Position: refs/heads/master@{#12693}

[kjellander_webrtc, 2016-05-12 06:11:19]

Committed patchset #2 (id:60001) manually as
3fe372dbee7d3c9ba7a58fd87c8df2e85decd73a.