Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: webrtc/media/media.gyp

Issue 1928653005: Fix all -Wnon-virtual-dtor warnings. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/engine/webrtcvideoengine2.h ('k') | webrtc/p2p/base/turnserver.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 { 9 {
10 'includes': [ '../build/common.gypi', ], 10 'includes': [ '../build/common.gypi', ],
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 ], 100 ],
101 # TODO(kjellander): Make the code compile without disabling these flags. 101 # TODO(kjellander): Make the code compile without disabling these flags.
102 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307 102 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307
103 'cflags': [ 103 'cflags': [
104 '-Wno-deprecated-declarations', 104 '-Wno-deprecated-declarations',
105 ], 105 ],
106 'cflags!': [ 106 'cflags!': [
107 '-Wextra', 107 '-Wextra',
108 ], 108 ],
109 'cflags_cc!': [ 109 'cflags_cc!': [
110 '-Wnon-virtual-dtor',
111 '-Woverloaded-virtual', 110 '-Woverloaded-virtual',
112 ], 111 ],
113 'msvs_disabled_warnings': [ 112 'msvs_disabled_warnings': [
114 4245, # conversion from 'int' to 'size_t', signed/unsigned mismatch. 113 4245, # conversion from 'int' to 'size_t', signed/unsigned mismatch.
115 4267, # conversion from 'size_t' to 'int', possible loss of data. 114 4267, # conversion from 'size_t' to 'int', possible loss of data.
116 4389, # signed/unsigned mismatch. 115 4389, # signed/unsigned mismatch.
117 ], 116 ],
118 'conditions': [ 117 'conditions': [
119 ['build_libyuv==1', { 118 ['build_libyuv==1', {
120 'dependencies': ['<(DEPTH)/third_party/libyuv/libyuv.gyp:libyuv',], 119 'dependencies': ['<(DEPTH)/third_party/libyuv/libyuv.gyp:libyuv',],
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 'base/testutils.h', 240 'base/testutils.h',
242 'engine/fakewebrtccall.cc', 241 'engine/fakewebrtccall.cc',
243 'engine/fakewebrtccall.h', 242 'engine/fakewebrtccall.h',
244 'engine/fakewebrtccommon.h', 243 'engine/fakewebrtccommon.h',
245 'engine/fakewebrtcdeviceinfo.h', 244 'engine/fakewebrtcdeviceinfo.h',
246 'engine/fakewebrtcvcmfactory.h', 245 'engine/fakewebrtcvcmfactory.h',
247 'engine/fakewebrtcvideocapturemodule.h', 246 'engine/fakewebrtcvideocapturemodule.h',
248 'engine/fakewebrtcvideoengine.h', 247 'engine/fakewebrtcvideoengine.h',
249 'engine/fakewebrtcvoiceengine.h', 248 'engine/fakewebrtcvoiceengine.h',
250 ], 249 ],
251 # TODO(kjellander): Make the code compile without disabling these flag s.
252 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307
253 'cflags_cc!': [
254 '-Wnon-virtual-dtor',
255 ],
256 }, # target rtc_unittest_main 250 }, # target rtc_unittest_main
257 { 251 {
258 'target_name': 'rtc_media_unittests', 252 'target_name': 'rtc_media_unittests',
259 'type': 'executable', 253 'type': 'executable',
260 'dependencies': [ 254 'dependencies': [
261 '<(webrtc_root)/base/base_tests.gyp:rtc_base_tests_utils', 255 '<(webrtc_root)/base/base_tests.gyp:rtc_base_tests_utils',
262 '<(webrtc_root)/media/media.gyp:rtc_media', 256 '<(webrtc_root)/media/media.gyp:rtc_media',
263 'rtc_unittest_main', 257 'rtc_unittest_main',
264 ], 258 ],
265 'sources': [ 259 'sources': [
(...skipping 18 matching lines...) Expand all
284 'engine/webrtcvideoengine2_unittest.cc', 278 'engine/webrtcvideoengine2_unittest.cc',
285 'engine/webrtcvoiceengine_unittest.cc', 279 'engine/webrtcvoiceengine_unittest.cc',
286 'sctp/sctpdataengine_unittest.cc', 280 'sctp/sctpdataengine_unittest.cc',
287 ], 281 ],
288 # TODO(kjellander): Make the code compile without disabling these flag s. 282 # TODO(kjellander): Make the code compile without disabling these flag s.
289 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307 283 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307
290 'cflags': [ 284 'cflags': [
291 '-Wno-sign-compare', 285 '-Wno-sign-compare',
292 ], 286 ],
293 'cflags_cc!': [ 287 'cflags_cc!': [
294 '-Wnon-virtual-dtor',
295 '-Woverloaded-virtual', 288 '-Woverloaded-virtual',
296 ], 289 ],
297 'msvs_disabled_warnings': [ 290 'msvs_disabled_warnings': [
298 4245, # conversion from 'int' to 'uint32_t', signed/unsigned mismat ch. 291 4245, # conversion from 'int' to 'uint32_t', signed/unsigned mismat ch.
299 4389, # signed/unsigned mismatch. 292 4389, # signed/unsigned mismatch.
300 ], 293 ],
301 'conditions': [ 294 'conditions': [
302 ['OS=="win"', { 295 ['OS=="win"', {
303 'msvs_settings': { 296 'msvs_settings': {
304 'VCLinkerTool': { 297 'VCLinkerTool': {
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
365 'sources': [ 358 'sources': [
366 'rtc_media_unittests.isolate', 359 'rtc_media_unittests.isolate',
367 ], 360 ],
368 }, 361 },
369 ], 362 ],
370 }], 363 }],
371 ], # conditions 364 ], # conditions
372 }], # include_tests==1 365 }], # include_tests==1
373 ], # conditions 366 ], # conditions
374 } 367 }
OLDNEW
« no previous file with comments | « webrtc/media/engine/webrtcvideoengine2.h ('k') | webrtc/p2p/base/turnserver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698