Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: webrtc/api/api_tests.gyp

Issue 1928653005: Fix all -Wnon-virtual-dtor warnings. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/api.gyp ('k') | webrtc/api/peerconnectionfactory_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 { 9 {
10 'includes': [ '../build/common.gypi', ], 10 'includes': [ '../build/common.gypi', ],
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 ], 65 ],
66 # TODO(kjellander): Make the code compile without disabling these flags. 66 # TODO(kjellander): Make the code compile without disabling these flags.
67 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307 67 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307
68 'cflags': [ 68 'cflags': [
69 '-Wno-sign-compare', 69 '-Wno-sign-compare',
70 ], 70 ],
71 'cflags!': [ 71 'cflags!': [
72 '-Wextra', 72 '-Wextra',
73 ], 73 ],
74 'cflags_cc!': [ 74 'cflags_cc!': [
75 '-Wnon-virtual-dtor',
76 '-Woverloaded-virtual', 75 '-Woverloaded-virtual',
77 ], 76 ],
78 'msvs_disabled_warnings': [ 77 'msvs_disabled_warnings': [
79 4245, # conversion from 'int' to 'size_t', signed/unsigned mismatch. 78 4245, # conversion from 'int' to 'size_t', signed/unsigned mismatch.
80 4267, # conversion from 'size_t' to 'int', possible loss of data. 79 4267, # conversion from 'size_t' to 'int', possible loss of data.
81 4389, # signed/unsigned mismatch. 80 4389, # signed/unsigned mismatch.
82 ], 81 ],
83 'conditions': [ 82 'conditions': [
84 ['clang==1', { 83 ['clang==1', {
85 # TODO(kjellander): Make the code compile without disabling these flag s. 84 # TODO(kjellander): Make the code compile without disabling these flag s.
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 '../build/isolate.gypi', 197 '../build/isolate.gypi',
199 ], 198 ],
200 'sources': [ 199 'sources': [
201 'peerconnection_unittests.isolate', 200 'peerconnection_unittests.isolate',
202 ], 201 ],
203 }, 202 },
204 ], # targets 203 ], # targets
205 }], # test_isolation_mode != "noop" 204 }], # test_isolation_mode != "noop"
206 ], # conditions 205 ], # conditions
207 } 206 }
OLDNEW
« no previous file with comments | « webrtc/api/api.gyp ('k') | webrtc/api/peerconnectionfactory_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698