Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: webrtc/media/base/codec.h

Issue 1928653005: Fix all -Wnon-virtual-dtor warnings. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/libjingle/xmpp/xmpp.gyp ('k') | webrtc/media/base/mediachannel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/base/codec.h
diff --git a/webrtc/media/base/codec.h b/webrtc/media/base/codec.h
index c16158ffb2bdb105ec5ef52a2146d7f9a3e22d79..76a623a0de8af540da8eeb777c18437ad9fdd352 100644
--- a/webrtc/media/base/codec.h
+++ b/webrtc/media/base/codec.h
@@ -73,7 +73,7 @@ struct Codec {
// Creates an empty codec.
Codec();
Codec(const Codec& c);
- ~Codec();
+ virtual ~Codec();
// Indicates if this codec is compatible with the specified codec.
bool Matches(const Codec& codec) const;
@@ -120,7 +120,7 @@ struct AudioCodec : public Codec {
// Creates an empty codec.
AudioCodec();
AudioCodec(const AudioCodec& c);
- ~AudioCodec() = default;
+ virtual ~AudioCodec() = default;
// Indicates if this codec is compatible with the specified codec.
bool Matches(const AudioCodec& codec) const;
@@ -153,7 +153,7 @@ struct VideoCodec : public Codec {
// Creates an empty codec.
VideoCodec();
VideoCodec(const VideoCodec& c);
- ~VideoCodec() = default;
+ virtual ~VideoCodec() = default;
std::string ToString() const;
@@ -186,6 +186,7 @@ struct DataCodec : public Codec {
DataCodec(int id, const std::string& name);
DataCodec();
DataCodec(const DataCodec& c);
+ virtual ~DataCodec() = default;
DataCodec& operator=(const DataCodec& c);
« no previous file with comments | « webrtc/libjingle/xmpp/xmpp.gyp ('k') | webrtc/media/base/mediachannel.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698