Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: webrtc/api/api.gyp

Issue 1928653005: Fix all -Wnon-virtual-dtor warnings. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/api/api_tests.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 { 9 {
10 'includes': [ '../build/common.gypi', ], 10 'includes': [ '../build/common.gypi', ],
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 # TODO(kjellander): Make the code compile without disabling these flag s. 59 # TODO(kjellander): Make the code compile without disabling these flag s.
60 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307 60 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307
61 'cflags': [ 61 'cflags': [
62 '-Wno-sign-compare', 62 '-Wno-sign-compare',
63 '-Wno-unused-variable', 63 '-Wno-unused-variable',
64 ], 64 ],
65 'cflags!': [ 65 'cflags!': [
66 '-Wextra', 66 '-Wextra',
67 ], 67 ],
68 'cflags_cc!': [ 68 'cflags_cc!': [
69 '-Wnon-virtual-dtor',
70 '-Woverloaded-virtual', 69 '-Woverloaded-virtual',
71 ], 70 ],
72 'msvs_disabled_warnings': [ 71 'msvs_disabled_warnings': [
73 4245, # conversion from 'int' to 'size_t', signed/unsigned mismatch . 72 4245, # conversion from 'int' to 'size_t', signed/unsigned mismatch .
74 4267, # conversion from 'size_t' to 'int', possible loss of data. 73 4267, # conversion from 'size_t' to 'int', possible loss of data.
75 4389, # signed/unsigned mismatch. 74 4389, # signed/unsigned mismatch.
76 ], 75 ],
77 }, 76 },
78 { 77 {
79 'target_name': 'libjingle_peerconnection_so', 78 'target_name': 'libjingle_peerconnection_so',
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 'webrtcsession.h', 199 'webrtcsession.h',
201 'webrtcsessiondescriptionfactory.cc', 200 'webrtcsessiondescriptionfactory.cc',
202 'webrtcsessiondescriptionfactory.h', 201 'webrtcsessiondescriptionfactory.h',
203 ], 202 ],
204 # TODO(kjellander): Make the code compile without disabling these flags. 203 # TODO(kjellander): Make the code compile without disabling these flags.
205 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307 204 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307
206 'cflags': [ 205 'cflags': [
207 '-Wno-sign-compare', 206 '-Wno-sign-compare',
208 ], 207 ],
209 'cflags_cc!': [ 208 'cflags_cc!': [
210 '-Wnon-virtual-dtor',
211 '-Woverloaded-virtual', 209 '-Woverloaded-virtual',
212 ], 210 ],
213 'conditions': [ 211 'conditions': [
214 ['clang==1', { 212 ['clang==1', {
215 'cflags!': [ 213 'cflags!': [
216 '-Wextra', 214 '-Wextra',
217 ], 215 ],
218 'xcode_settings': { 216 'xcode_settings': {
219 'WARNING_CFLAGS!': ['-Wextra'], 217 'WARNING_CFLAGS!': ['-Wextra'],
220 }, 218 },
(...skipping 30 matching lines...) Expand all
251 'quicdatatransport.h', 249 'quicdatatransport.h',
252 ], 250 ],
253 'export_dependent_settings': [ 251 'export_dependent_settings': [
254 '<(DEPTH)/third_party/libquic/libquic.gyp:libquic', 252 '<(DEPTH)/third_party/libquic/libquic.gyp:libquic',
255 ], 253 ],
256 }], 254 }],
257 ], 255 ],
258 }, # target libjingle_peerconnection 256 }, # target libjingle_peerconnection
259 ], # targets 257 ], # targets
260 } 258 }
OLDNEW
« no previous file with comments | « no previous file | webrtc/api/api_tests.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698