Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: webrtc/media/base/mediachannel.h

Issue 1928653005: Fix all -Wnon-virtual-dtor warnings. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/base/codec.h ('k') | webrtc/media/engine/webrtcvideoengine2.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 823 matching lines...) Expand 10 before | Expand all | Expand 10 after
834 ost << "codecs: " << VectorToString(codecs) << ", "; 834 ost << "codecs: " << VectorToString(codecs) << ", ";
835 ost << "extensions: " << VectorToString(extensions); 835 ost << "extensions: " << VectorToString(extensions);
836 ost << "}"; 836 ost << "}";
837 return ost.str(); 837 return ost.str();
838 } 838 }
839 839
840 std::vector<Codec> codecs; 840 std::vector<Codec> codecs;
841 std::vector<RtpHeaderExtension> extensions; 841 std::vector<RtpHeaderExtension> extensions;
842 // TODO(pthatcher): Add streams. 842 // TODO(pthatcher): Add streams.
843 RtcpParameters rtcp; 843 RtcpParameters rtcp;
844 virtual ~RtpParameters() = default;
844 }; 845 };
845 846
846 // TODO(deadbeef): Rename to RtpSenderParameters, since they're intended to 847 // TODO(deadbeef): Rename to RtpSenderParameters, since they're intended to
847 // encapsulate all the parameters needed for an RtpSender. 848 // encapsulate all the parameters needed for an RtpSender.
848 template <class Codec> 849 template <class Codec>
849 struct RtpSendParameters : RtpParameters<Codec> { 850 struct RtpSendParameters : RtpParameters<Codec> {
850 std::string ToString() const override { 851 std::string ToString() const override {
851 std::ostringstream ost; 852 std::ostringstream ost;
852 ost << "{"; 853 ost << "{";
853 ost << "codecs: " << VectorToString(this->codecs) << ", "; 854 ost << "codecs: " << VectorToString(this->codecs) << ", ";
(...skipping 272 matching lines...) Expand 10 before | Expand all | Expand 10 after
1126 // Signal when the media channel is ready to send the stream. Arguments are: 1127 // Signal when the media channel is ready to send the stream. Arguments are:
1127 // writable(bool) 1128 // writable(bool)
1128 sigslot::signal1<bool> SignalReadyToSend; 1129 sigslot::signal1<bool> SignalReadyToSend;
1129 // Signal for notifying that the remote side has closed the DataChannel. 1130 // Signal for notifying that the remote side has closed the DataChannel.
1130 sigslot::signal1<uint32_t> SignalStreamClosedRemotely; 1131 sigslot::signal1<uint32_t> SignalStreamClosedRemotely;
1131 }; 1132 };
1132 1133
1133 } // namespace cricket 1134 } // namespace cricket
1134 1135
1135 #endif // WEBRTC_MEDIA_BASE_MEDIACHANNEL_H_ 1136 #endif // WEBRTC_MEDIA_BASE_MEDIACHANNEL_H_
OLDNEW
« no previous file with comments | « webrtc/media/base/codec.h ('k') | webrtc/media/engine/webrtcvideoengine2.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698