Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: webrtc/base/BUILD.gn

Issue 1928653005: Fix all -Wnon-virtual-dtor warnings. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/webrtcsession_unittest.cc ('k') | webrtc/base/base.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/BUILD.gn
diff --git a/webrtc/base/BUILD.gn b/webrtc/base/BUILD.gn
index 63c2da533e5ab3cf3e40292e411105f6cceba9c4..cd7e5b51e598d40cdfce7e8be807309456bcd74c 100644
--- a/webrtc/base/BUILD.gn
+++ b/webrtc/base/BUILD.gn
@@ -28,12 +28,6 @@ config("rtc_base_config") {
"FEATURE_ENABLE_SSL",
"LOGGING=1",
]
-
- if (is_posix) {
- # TODO(henrike): issue 3307, make rtc_base build without disabling
- # these flags.
- cflags_cc = [ "-Wno-non-virtual-dtor" ]
- }
}
config("rtc_base_chromium_config") {
@@ -470,7 +464,6 @@ static_library("rtc_base") {
configs += [ "//build/config/compiler:no_chromium_code" ]
if (!is_win) {
cflags += [ "-Wno-uninitialized" ]
- cflags_cc += [ "-Wno-non-virtual-dtor" ]
}
if (rtc_build_ssl) {
« no previous file with comments | « webrtc/api/webrtcsession_unittest.cc ('k') | webrtc/base/base.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698