Move talk/app/webrtc to webrtc/api

Move talk/app/webrtc to webrtc/api

The previously disabled warnings that were inherited from
talk/build/common.gypi are now replaced by target-specific disabling
of only the failing warnings. Additional disabling was needed since the stricter
compilation warnings that applies to code in webrtc/.

License headers will be updated in a follow-up CL.

Other modifications:
* Updated the header guards.
* Sorted the includes using chromium/src/tools/sort-headers.py
  except for these files:
  talk/app/webrtc/peerconnectionendtoend_unittest.cc
  talk/app/webrtc/java/jni/androidmediadecoder_jni.cc
  talk/app/webrtc/java/jni/androidmediaencoder_jni.cc
  webrtc/media/devices/win32devicemanager.cc

The HAVE_SCTP define was added for the peerconnection_unittests target
in api_tests.gyp.

I also checked that none of
SRTP_RELATIVE_PATH
HAVE_SRTP
HAVE_WEBRTC_VIDEO
HAVE_WEBRTC_VOICE
were used by the talk/app/webrtc code.

For Chromium, the following changes will need to be applied to the roll CL that updates the
DEPS for WebRTC and libjingle:
https://codereview.chromium.org/1615433002

BUG=webrtc:5418
NOPRESUBMIT=True
R=deadbeef@webrtc.org, pthatcher@webrtc.org, tommi@webrtc.org

Committed: https://crrev.com/15583c19d7d491d53f9bf9c0f6d15a734b0a473d
Cr-Commit-Position: refs/heads/master@{#11545}

[kjellander_webrtc, 2016-01-20 19:21:17]

Patchset #3 (id:10002) has been deleted

[kjellander_webrtc, 2016-01-20 19:21:40]

Patchset #2 (id:10001) has been deleted

[kjellander_webrtc, 2016-01-20 21:12:35]

Patchset #1 (id:1) has been deleted

[kjellander_webrtc, 2016-01-20 21:14:56]

Description was changed from

==========
Move talk/app/webrtc to webrtc/api

Modifications:
* Updated the header guards.
* Sorted the includes using chromium/src/tools/sort-headers.py
  except for these files:
  talk/app/webrtc/peerconnectionendtoend_unittest.cc
  talk/app/webrtc/java/jni/androidmediadecoder_jni.cc
  talk/app/webrtc/java/jni/androidmediaencoder_jni.cc
  webrtc/media/devices/win32devicemanager.cc

The HAVE_SCTP define was added for the peerconnection_unittests target
in api_tests.gyp.

I also checked that none of
SRTP_RELATIVE_PATH
HAVE_SRTP
HAVE_WEBRTC_VIDEO
HAVE_WEBRTC_VOICE
were used by the talk/app/webrtc code.

BUG=webrtc:5418
==========

to

==========
Move talk/app/webrtc to webrtc/api

Modifications:
* Updated the header guards.
* Sorted the includes using chromium/src/tools/sort-headers.py
  except for these files:
  talk/app/webrtc/peerconnectionendtoend_unittest.cc
  talk/app/webrtc/java/jni/androidmediadecoder_jni.cc
  talk/app/webrtc/java/jni/androidmediaencoder_jni.cc
  webrtc/media/devices/win32devicemanager.cc

The HAVE_SCTP define was added for the peerconnection_unittests target
in api_tests.gyp.

I also checked that none of
SRTP_RELATIVE_PATH
HAVE_SRTP
HAVE_WEBRTC_VIDEO
HAVE_WEBRTC_VOICE
were used by the talk/app/webrtc code.

For Chromium, the following changes will need to be applied to the roll CL that
updates the
DEPS for WebRTC and libjingle: 
https://codereview.chromium.org/1615433002

BUG=webrtc:5418
==========

[kjellander_webrtc, 2016-01-21 12:42:18]

Patchset #4 (id:50001) has been deleted

[kjellander_webrtc, 2016-01-22 08:48:23]

Description was changed from

==========
Move talk/app/webrtc to webrtc/api

Modifications:
* Updated the header guards.
* Sorted the includes using chromium/src/tools/sort-headers.py
  except for these files:
  talk/app/webrtc/peerconnectionendtoend_unittest.cc
  talk/app/webrtc/java/jni/androidmediadecoder_jni.cc
  talk/app/webrtc/java/jni/androidmediaencoder_jni.cc
  webrtc/media/devices/win32devicemanager.cc

The HAVE_SCTP define was added for the peerconnection_unittests target
in api_tests.gyp.

I also checked that none of
SRTP_RELATIVE_PATH
HAVE_SRTP
HAVE_WEBRTC_VIDEO
HAVE_WEBRTC_VOICE
were used by the talk/app/webrtc code.

For Chromium, the following changes will need to be applied to the roll CL that
updates the
DEPS for WebRTC and libjingle: 
https://codereview.chromium.org/1615433002

BUG=webrtc:5418
==========

to

==========
Move talk/app/webrtc to webrtc/api

Modifications:
* Updated the header guards.
* Sorted the includes using chromium/src/tools/sort-headers.py
  except for these files:
  talk/app/webrtc/peerconnectionendtoend_unittest.cc
  talk/app/webrtc/java/jni/androidmediadecoder_jni.cc
  talk/app/webrtc/java/jni/androidmediaencoder_jni.cc
  webrtc/media/devices/win32devicemanager.cc

The HAVE_SCTP define was added for the peerconnection_unittests target
in api_tests.gyp.

The previously disabled warnings that were inherited from
talk/build/common.gypi are now replaced by target-specific disabling
of only the failing warnings. Additional disabling was needed since the stricter
compilation warnings that applies to code in webrtc/.

I also checked that none of
SRTP_RELATIVE_PATH
HAVE_SRTP
HAVE_WEBRTC_VIDEO
HAVE_WEBRTC_VOICE
were used by the talk/app/webrtc code.

For Chromium, the following changes will need to be applied to the roll CL that
updates the
DEPS for WebRTC and libjingle: 
https://codereview.chromium.org/1615433002

BUG=webrtc:5418
==========

[kjellander_webrtc, 2016-01-22 08:49:03]

Description was changed from

==========
Move talk/app/webrtc to webrtc/api

Modifications:
* Updated the header guards.
* Sorted the includes using chromium/src/tools/sort-headers.py
  except for these files:
  talk/app/webrtc/peerconnectionendtoend_unittest.cc
  talk/app/webrtc/java/jni/androidmediadecoder_jni.cc
  talk/app/webrtc/java/jni/androidmediaencoder_jni.cc
  webrtc/media/devices/win32devicemanager.cc

The HAVE_SCTP define was added for the peerconnection_unittests target
in api_tests.gyp.

The previously disabled warnings that were inherited from
talk/build/common.gypi are now replaced by target-specific disabling
of only the failing warnings. Additional disabling was needed since the stricter
compilation warnings that applies to code in webrtc/.

I also checked that none of
SRTP_RELATIVE_PATH
HAVE_SRTP
HAVE_WEBRTC_VIDEO
HAVE_WEBRTC_VOICE
were used by the talk/app/webrtc code.

For Chromium, the following changes will need to be applied to the roll CL that
updates the
DEPS for WebRTC and libjingle: 
https://codereview.chromium.org/1615433002

BUG=webrtc:5418
==========

to

==========
Move talk/app/webrtc to webrtc/api

The previously disabled warnings that were inherited from
talk/build/common.gypi are now replaced by target-specific disabling
of only the failing warnings. Additional disabling was needed since the stricter
compilation warnings that applies to code in webrtc/.

Other modifications:
* Updated the header guards.
* Sorted the includes using chromium/src/tools/sort-headers.py
  except for these files:
  talk/app/webrtc/peerconnectionendtoend_unittest.cc
  talk/app/webrtc/java/jni/androidmediadecoder_jni.cc
  talk/app/webrtc/java/jni/androidmediaencoder_jni.cc
  webrtc/media/devices/win32devicemanager.cc

The HAVE_SCTP define was added for the peerconnection_unittests target
in api_tests.gyp.

I also checked that none of
SRTP_RELATIVE_PATH
HAVE_SRTP
HAVE_WEBRTC_VIDEO
HAVE_WEBRTC_VOICE
were used by the talk/app/webrtc code.

For Chromium, the following changes will need to be applied to the roll CL that
updates the
DEPS for WebRTC and libjingle: 
https://codereview.chromium.org/1615433002

BUG=webrtc:5418
==========

[kjellander_webrtc, 2016-01-22 10:18:19]

The CQ bit was checked by kjellander@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-22 10:18:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1610243002/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1610243002/110001

[commit-bot: I haz the power, 2016-01-22 10:24:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-22 10:24:33]

Dry run: Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3024)

[kjellander_webrtc, 2016-01-23 04:56:09]

kjellander@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, pthatcher@webrtc.org, tommi@webrtc.org

[kjellander_webrtc, 2016-01-23 04:56:12]

This is now finally ready for review (will require more rebases since I'm OOO
next week). 
See PS#9 for passing tryjobs.

Regarding the failure on Android, it happens due to the path to the
peerconnection_unittests.isolate file, which have to change (needs to be in the
same dir as the test target is specified in GYP).
I thought PS#10 would fix it, but the path is hardcoded on the buildbot side so
there's no way to fix that. I have run the test locally on my Linux workstation
with this patch applied and it passes so I'm confident that it's OK.

See the bug for some details of what has been done in this CL.

[Taylor Brandstetter, 2016-02-05 18:59:44]

https://codereview.webrtc.org/1610243002/diff/120001/webrtc/api/audiotrack.h
File webrtc/api/audiotrack.h (right):

https://codereview.webrtc.org/1610243002/diff/120001/webrtc/api/audiotrack.h#...
webrtc/api/audiotrack.h:9: */
Same as before, would it be possible to restore the old copyright notice, so
this is counted as a "move" instead of "delete/add"?

[pthatcher1, 2016-02-05 21:18:49]

It's happening!

https://codereview.webrtc.org/1610243002/diff/120001/talk/libjingle.gyp
File talk/libjingle.gyp (right):

https://codereview.webrtc.org/1610243002/diff/120001/talk/libjingle.gyp#newco...
talk/libjingle.gyp:31: # The >= 10.7 above is required for ARC.
Shouldn't we (re)move this target also?  I thought the files are being moved.

https://codereview.webrtc.org/1610243002/diff/120001/webrtc/api/OWNERS
File webrtc/api/OWNERS (right):

https://codereview.webrtc.org/1610243002/diff/120001/webrtc/api/OWNERS#newcode5
webrtc/api/OWNERS:5: tommi@webrtc.org
Not to be conceited, but I think I should be in the list

https://codereview.webrtc.org/1610243002/diff/120001/webrtc/api/audiotrack.h
File webrtc/api/audiotrack.h (right):

https://codereview.webrtc.org/1610243002/diff/120001/webrtc/api/audiotrack.h#...
webrtc/api/audiotrack.h:9: */
On 2016/02/05 18:59:44, Taylor Brandstetter wrote:
> Same as before, would it be possible to restore the old copyright notice, so
> this is counted as a "move" instead of "delete/add"?

Agreed, although I only saw 5 or files that failed this time, so maybe just
unchanging the notice on those files would suffice.

https://codereview.webrtc.org/1610243002/diff/120001/webrtc/api/java/testcomm...
File webrtc/api/java/testcommon/src/org/webrtc/PeerConnectionTest.java (right):

https://codereview.webrtc.org/1610243002/diff/120001/webrtc/api/java/testcomm...
webrtc/api/java/testcommon/src/org/webrtc/PeerConnectionTest.java:26: */
Is it our intention to change the copyright on these also?  Does your
auto-changer tool just miss Java files?

[kjellander_webrtc, 2016-02-08 06:27:06]

Patchset #11 (id:130001) has been deleted

[kjellander_webrtc, 2016-02-08 07:55:35]

The CQ bit was checked by kjellander@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-08 07:55:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1610243002/150001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1610243002/150001

[commit-bot: I haz the power, 2016-02-08 08:04:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-08 08:04:36]

Dry run: Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3291)

[kjellander_webrtc, 2016-02-08 08:25:51]

Description was changed from

==========
Move talk/app/webrtc to webrtc/api

The previously disabled warnings that were inherited from
talk/build/common.gypi are now replaced by target-specific disabling
of only the failing warnings. Additional disabling was needed since the stricter
compilation warnings that applies to code in webrtc/.

Other modifications:
* Updated the header guards.
* Sorted the includes using chromium/src/tools/sort-headers.py
  except for these files:
  talk/app/webrtc/peerconnectionendtoend_unittest.cc
  talk/app/webrtc/java/jni/androidmediadecoder_jni.cc
  talk/app/webrtc/java/jni/androidmediaencoder_jni.cc
  webrtc/media/devices/win32devicemanager.cc

The HAVE_SCTP define was added for the peerconnection_unittests target
in api_tests.gyp.

I also checked that none of
SRTP_RELATIVE_PATH
HAVE_SRTP
HAVE_WEBRTC_VIDEO
HAVE_WEBRTC_VOICE
were used by the talk/app/webrtc code.

For Chromium, the following changes will need to be applied to the roll CL that
updates the
DEPS for WebRTC and libjingle: 
https://codereview.chromium.org/1615433002

BUG=webrtc:5418
==========

to

==========
Move talk/app/webrtc to webrtc/api

The previously disabled warnings that were inherited from
talk/build/common.gypi are now replaced by target-specific disabling
of only the failing warnings. Additional disabling was needed since the stricter
compilation warnings that applies to code in webrtc/.

License headers will be updated in a follow-up CL.

Other modifications:
* Updated the header guards.
* Sorted the includes using chromium/src/tools/sort-headers.py
  except for these files:
  talk/app/webrtc/peerconnectionendtoend_unittest.cc
  talk/app/webrtc/java/jni/androidmediadecoder_jni.cc
  talk/app/webrtc/java/jni/androidmediaencoder_jni.cc
  webrtc/media/devices/win32devicemanager.cc

The HAVE_SCTP define was added for the peerconnection_unittests target
in api_tests.gyp.

I also checked that none of
SRTP_RELATIVE_PATH
HAVE_SRTP
HAVE_WEBRTC_VIDEO
HAVE_WEBRTC_VOICE
were used by the talk/app/webrtc code.

For Chromium, the following changes will need to be applied to the roll CL that
updates the
DEPS for WebRTC and libjingle: 
https://codereview.chromium.org/1615433002

BUG=webrtc:5418
NOPRESUBMIT=True
==========

[kjellander_webrtc, 2016-02-08 09:12:06]

Alles grün und gut!
Please have a look right away to spare me from more rebase-pain.

https://codereview.webrtc.org/1610243002/diff/120001/talk/libjingle.gyp
File talk/libjingle.gyp (right):

https://codereview.webrtc.org/1610243002/diff/120001/talk/libjingle.gyp#newco...
talk/libjingle.gyp:31: # The >= 10.7 above is required for ARC.
On 2016/02/05 21:18:49, pthatcher1 wrote:
> Shouldn't we (re)move this target also?  I thought the files are being moved.

No, Zeke wanted to let the ObjC files stay, since there's already a new ObjC API
built in webrtc/api. See
https://bugs.chromium.org/p/webrtc/issues/detail?id=5418#c2

https://codereview.webrtc.org/1610243002/diff/120001/webrtc/api/OWNERS
File webrtc/api/OWNERS (right):

https://codereview.webrtc.org/1610243002/diff/120001/webrtc/api/OWNERS#newcode5
webrtc/api/OWNERS:5: tommi@webrtc.org
On 2016/02/05 21:18:49, pthatcher1 wrote:
> Not to be conceited, but I think I should be in the list

heh, certainly!
This was just the moved
https://chromium.googlesource.com/external/webrtc/+/master/talk/app/webrtc/OW....
I guess you weren't in it since you were already in
https://chromium.googlesource.com/external/webrtc/+/master/talk/OWNERS. Are
there any more from that you think should be added here?

https://codereview.webrtc.org/1610243002/diff/120001/webrtc/api/audiotrack.h
File webrtc/api/audiotrack.h (right):

https://codereview.webrtc.org/1610243002/diff/120001/webrtc/api/audiotrack.h#...
webrtc/api/audiotrack.h:9: */
On 2016/02/05 21:18:49, pthatcher1 wrote:
> On 2016/02/05 18:59:44, Taylor Brandstetter wrote:
> > Same as before, would it be possible to restore the old copyright notice, so
> > this is counted as a "move" instead of "delete/add"?
> 
> Agreed, although I only saw 5 or files that failed this time, so maybe just
> unchanging the notice on those files would suffice.

It's easy to do, so I restored them all and will make a follow-up CL with only
license changes.

https://codereview.webrtc.org/1610243002/diff/120001/webrtc/api/java/testcomm...
File webrtc/api/java/testcommon/src/org/webrtc/PeerConnectionTest.java (right):

https://codereview.webrtc.org/1610243002/diff/120001/webrtc/api/java/testcomm...
webrtc/api/java/testcommon/src/org/webrtc/PeerConnectionTest.java:26: */
On 2016/02/05 21:18:49, pthatcher1 wrote:
> Is it our intention to change the copyright on these also?  Does your
> auto-changer tool just miss Java files?

They should be changed too. I'll make sure check they're also updated in my
follow-up CL.

[tommi, 2016-02-08 18:51:28]

lgtm

[Taylor Brandstetter, 2016-02-08 20:47:30]

lgtm

[pthatcher1, 2016-02-09 22:10:06]

lgtm

[kjellander_webrtc, 2016-02-10 07:05:51]

The CQ bit was checked by kjellander@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-10 07:06:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1610243002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1610243002/160001

[commit-bot: I haz the power, 2016-02-10 08:08:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 08:08:06]

Dry run: This issue passed the CQ dry run.

[kjellander_webrtc, 2016-02-10 08:49:43]

kjellander@webrtc.org changed reviewers:
+ tkchin@webrtc.org

[kjellander_webrtc, 2016-02-10 09:52:43]

On 2016/02/10 08:08:06, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

+tkchin since I changed webrtc/webrtc.gyp regarding how api/api.gyp:* is
included in the GYP chain. I had to do that change in order to get this passing
the GYP generation when built from Chromium. We'll have to update that once
talk/ is migrated and I'll start working on eliminating the
src/third_party/libjingle/libjingle.gyp file in Chromium.

[kjellander_webrtc, 2016-02-10 09:53:31]

Description was changed from

==========
Move talk/app/webrtc to webrtc/api

The previously disabled warnings that were inherited from
talk/build/common.gypi are now replaced by target-specific disabling
of only the failing warnings. Additional disabling was needed since the stricter
compilation warnings that applies to code in webrtc/.

License headers will be updated in a follow-up CL.

Other modifications:
* Updated the header guards.
* Sorted the includes using chromium/src/tools/sort-headers.py
  except for these files:
  talk/app/webrtc/peerconnectionendtoend_unittest.cc
  talk/app/webrtc/java/jni/androidmediadecoder_jni.cc
  talk/app/webrtc/java/jni/androidmediaencoder_jni.cc
  webrtc/media/devices/win32devicemanager.cc

The HAVE_SCTP define was added for the peerconnection_unittests target
in api_tests.gyp.

I also checked that none of
SRTP_RELATIVE_PATH
HAVE_SRTP
HAVE_WEBRTC_VIDEO
HAVE_WEBRTC_VOICE
were used by the talk/app/webrtc code.

For Chromium, the following changes will need to be applied to the roll CL that
updates the
DEPS for WebRTC and libjingle: 
https://codereview.chromium.org/1615433002

BUG=webrtc:5418
NOPRESUBMIT=True
==========

to

==========
Move talk/app/webrtc to webrtc/api

The previously disabled warnings that were inherited from
talk/build/common.gypi are now replaced by target-specific disabling
of only the failing warnings. Additional disabling was needed since the stricter
compilation warnings that applies to code in webrtc/.

License headers will be updated in a follow-up CL.

Other modifications:
* Updated the header guards.
* Sorted the includes using chromium/src/tools/sort-headers.py
  except for these files:
  talk/app/webrtc/peerconnectionendtoend_unittest.cc
  talk/app/webrtc/java/jni/androidmediadecoder_jni.cc
  talk/app/webrtc/java/jni/androidmediaencoder_jni.cc
  webrtc/media/devices/win32devicemanager.cc

The HAVE_SCTP define was added for the peerconnection_unittests target
in api_tests.gyp.

I also checked that none of
SRTP_RELATIVE_PATH
HAVE_SRTP
HAVE_WEBRTC_VIDEO
HAVE_WEBRTC_VOICE
were used by the talk/app/webrtc code.

For Chromium, the following changes will need to be applied to the roll CL that
updates the
DEPS for WebRTC and libjingle:
https://codereview.chromium.org/1615433002

BUG=webrtc:5418
NOPRESUBMIT=True
R=deadbeef@webrtc.org, pthatcher@webrtc.org, tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/15583c19d7d491d53f9bf9c0f...
==========

[kjellander_webrtc, 2016-02-10 09:53:33]

Committed patchset #14 (id:170001) manually as
15583c19d7d491d53f9bf9c0f6d15a734b0a473d.

[commit-bot: I haz the power, 2016-02-10 09:53:37]

Description was changed from

==========
Move talk/app/webrtc to webrtc/api

The previously disabled warnings that were inherited from
talk/build/common.gypi are now replaced by target-specific disabling
of only the failing warnings. Additional disabling was needed since the stricter
compilation warnings that applies to code in webrtc/.

License headers will be updated in a follow-up CL.

Other modifications:
* Updated the header guards.
* Sorted the includes using chromium/src/tools/sort-headers.py
  except for these files:
  talk/app/webrtc/peerconnectionendtoend_unittest.cc
  talk/app/webrtc/java/jni/androidmediadecoder_jni.cc
  talk/app/webrtc/java/jni/androidmediaencoder_jni.cc
  webrtc/media/devices/win32devicemanager.cc

The HAVE_SCTP define was added for the peerconnection_unittests target
in api_tests.gyp.

I also checked that none of
SRTP_RELATIVE_PATH
HAVE_SRTP
HAVE_WEBRTC_VIDEO
HAVE_WEBRTC_VOICE
were used by the talk/app/webrtc code.

For Chromium, the following changes will need to be applied to the roll CL that
updates the
DEPS for WebRTC and libjingle:
https://codereview.chromium.org/1615433002

BUG=webrtc:5418
NOPRESUBMIT=True
R=deadbeef@webrtc.org, pthatcher@webrtc.org, tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/15583c19d7d491d53f9bf9c0f...
==========

to

==========
Move talk/app/webrtc to webrtc/api

The previously disabled warnings that were inherited from
talk/build/common.gypi are now replaced by target-specific disabling
of only the failing warnings. Additional disabling was needed since the stricter
compilation warnings that applies to code in webrtc/.

License headers will be updated in a follow-up CL.

Other modifications:
* Updated the header guards.
* Sorted the includes using chromium/src/tools/sort-headers.py
  except for these files:
  talk/app/webrtc/peerconnectionendtoend_unittest.cc
  talk/app/webrtc/java/jni/androidmediadecoder_jni.cc
  talk/app/webrtc/java/jni/androidmediaencoder_jni.cc
  webrtc/media/devices/win32devicemanager.cc

The HAVE_SCTP define was added for the peerconnection_unittests target
in api_tests.gyp.

I also checked that none of
SRTP_RELATIVE_PATH
HAVE_SRTP
HAVE_WEBRTC_VIDEO
HAVE_WEBRTC_VOICE
were used by the talk/app/webrtc code.

For Chromium, the following changes will need to be applied to the roll CL that
updates the
DEPS for WebRTC and libjingle:
https://codereview.chromium.org/1615433002

BUG=webrtc:5418
NOPRESUBMIT=True
R=deadbeef@webrtc.org, pthatcher@webrtc.org, tommi@webrtc.org

Committed: https://crrev.com/15583c19d7d491d53f9bf9c0f6d15a734b0a473d
Cr-Commit-Position: refs/heads/master@{#11545}
==========

[commit-bot: I haz the power, 2016-02-10 09:53:40]

Patchset 14 (id:??) landed as
https://crrev.com/15583c19d7d491d53f9bf9c0f6d15a734b0a473d
Cr-Commit-Position: refs/heads/master@{#11545}

[tkchin_webrtc, 2016-02-10 19:30:37]

On 2016/02/10 09:53:40, commit-bot: I haz the power wrote:
> Patchset 14 (id:??) landed as
> https://crrev.com/15583c19d7d491d53f9bf9c0f6d15a734b0a473d
> Cr-Commit-Position: refs/heads/master@{#11545}

lgtm
nice.