Use suffixed {uint,int}{8,16,32,64}_t types.

Use suffixed {uint,int}{8,16,32,64}_t types.

Removes the use of uint8, etc. in favor of uint8_t.

BUG=webrtc:5024
R=henrik.lundin@webrtc.org, henrikg@webrtc.org, perkj@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, tina.legrand@webrtc.org

Committed: https://crrev.com/0c4e06b4c6107a1b94f764e279e4fb4161e905b0
Cr-Commit-Position: refs/heads/master@{#10196}

[pbos-webrtc, 2015-09-22 09:32:40]

add back stdint.h to webrtc/typdefs.h

[pbos-webrtc, 2015-09-22 09:37:36]

Basically doing s/\<uint32\>/uint32_t/g in all our files.

Then git cl format.
Then reverting matlab files.
Then reverting a google::int32 in neteq_replay.cc which got replaced by
google::int32_t inadvertently.

PTAL, or glance, or stuff. Check the file list to see that I'm not converting
for any weird filetypes.

[hlundin-webrtc, 2015-09-22 09:57:30]

henrik.lundin@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[hlundin-webrtc, 2015-09-22 09:57:31]

webrtc/modules/audio_processing: not lgtm

You changed the file suffix on our AEC debug dump files. Don't do that, please.
Except for that, all you did in audio_processing was changes in comments, which
is unnecessary.

https://codereview.webrtc.org/1362503003/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/test/unpack.cc (right):

https://codereview.webrtc.org/1362503003/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/unpack.cc:31: DEFINE_string(delay_file,
"delay.int32_t", "The name of the delay file.");
Don't change these. They are file names.

https://codereview.webrtc.org/1362503003/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/transient/transient_suppressor.h (right):

https://codereview.webrtc.org/1362503003/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/transient/transient_suppressor.h:36: // than
Malformed comment; 'than' dangling on it's own line.

[Henrik Grunell WebRTC, 2015-09-22 10:35:55]

Agree with Henrik L. You'll have to go through the changes and fix comments etc.

Apart from that, please file a bug.

https://codereview.webrtc.org/1362503003/diff/20001/webrtc/base/basictypes_un...
File webrtc/base/basictypes_unittest.cc (right):

https://codereview.webrtc.org/1362503003/diff/20001/webrtc/base/basictypes_un...
webrtc/base/basictypes_unittest.cc:17: static_assert(sizeof(int8_t) == 1,
"Unexpected size");
Remove these asserts. Size of _t types are guaranteed.

https://codereview.webrtc.org/1362503003/diff/20001/webrtc/base/basictypes_un...
webrtc/base/basictypes_unittest.cc:36: TEST(BasicTypesTest, SizeOfTypes) {
Same here. Remove test.

https://codereview.webrtc.org/1362503003/diff/20001/webrtc/typedefs.h
File webrtc/typedefs.h (right):

https://codereview.webrtc.org/1362503003/diff/20001/webrtc/typedefs.h#newcode65
webrtc/typedefs.h:65: // TODO(pbos): Use stdint.h directly from headers
requiring _t int types.
Actually, I think it's fine including it implicitly. I'd prefer one include over
several. (E.g. also stddef.h for size_t.) However, basictypes.h should be the
header to include for types. Can we remove stdint.h from here? What's the
difference between basictypes.h and typedefs.h really?

[pbos-webrtc, 2015-09-22 12:17:09]

revert some webrtc dirs + fix formatting

[pbos-webrtc, 2015-09-22 12:17:42]

PTAL, I think we're friends again henrik.lundin@.

I went through lines that touched strings and comments. Some changes (uint32 ->
uint32_t) in comments that didn't cause bad comment formatting I left alone, but
I removed ones that forced a line wrap for a single word.

https://codereview.webrtc.org/1362503003/diff/20001/webrtc/base/basictypes_un...
File webrtc/base/basictypes_unittest.cc (right):

https://codereview.webrtc.org/1362503003/diff/20001/webrtc/base/basictypes_un...
webrtc/base/basictypes_unittest.cc:17: static_assert(sizeof(int8_t) == 1,
"Unexpected size");
On 2015/09/22 10:35:54, Henrik Grunell (webrtc) wrote:
> Remove these asserts. Size of _t types are guaranteed.

Done.

https://codereview.webrtc.org/1362503003/diff/20001/webrtc/base/basictypes_un...
webrtc/base/basictypes_unittest.cc:36: TEST(BasicTypesTest, SizeOfTypes) {
On 2015/09/22 10:35:54, Henrik Grunell (webrtc) wrote:
> Same here. Remove test.

Done.

https://codereview.webrtc.org/1362503003/diff/20001/webrtc/typedefs.h
File webrtc/typedefs.h (right):

https://codereview.webrtc.org/1362503003/diff/20001/webrtc/typedefs.h#newcode65
webrtc/typedefs.h:65: // TODO(pbos): Use stdint.h directly from headers
requiring _t int types.
On 2015/09/22 10:35:54, Henrik Grunell (webrtc) wrote:
> Actually, I think it's fine including it implicitly. I'd prefer one include
over
> several. (E.g. also stddef.h for size_t.) However, basictypes.h should be the
> header to include for types. Can we remove stdint.h from here? What's the
> difference between basictypes.h and typedefs.h really?

Updated TODO.

[hlundin-webrtc, 2015-09-22 12:27:49]

lgtm for removing webrtc/modules/audio_processing.
lgtm for webrtc/voice_engine (although I am not an OWNER).

[Henrik Grunell WebRTC, 2015-09-30 08:23:47]

Peter: did you clear this CL with Tommi?

[pbos-webrtc, 2015-09-30 09:14:17]

On 2015/09/30 08:23:47, Henrik Grunell (webrtc) wrote:
> Peter: did you clear this CL with Tommi?

Yeah, but I think I should split it up into reviewable chunks instead of one
master chunk. Let me know if you want me to prioritize doing this quickly
otherwise I'll do some of it while I need some more braindead task. :)

[Henrik Grunell WebRTC, 2015-09-30 09:53:20]

On 2015/09/30 09:14:17, pbos-webrtc wrote:
> On 2015/09/30 08:23:47, Henrik Grunell (webrtc) wrote:
> > Peter: did you clear this CL with Tommi?
> 
> Yeah, but I think I should split it up into reviewable chunks instead of one
> master chunk. Let me know if you want me to prioritize doing this quickly
> otherwise I'll do some of it while I need some more braindead task. :)

Ah right, you were going to split it. No rush at all, just wanted to make sure
you weren't waiting for me.

[kjellander (google.com), 2015-10-05 05:21:31]

On 2015/09/30 09:53:20, Henrik Grunell (webrtc) wrote:
> On 2015/09/30 09:14:17, pbos-webrtc wrote:
> > On 2015/09/30 08:23:47, Henrik Grunell (webrtc) wrote:
> > > Peter: did you clear this CL with Tommi?
> > 
> > Yeah, but I think I should split it up into reviewable chunks instead of one
> > master chunk. Let me know if you want me to prioritize doing this quickly
> > otherwise I'll do some of it while I need some more braindead task. :)
> 
> Ah right, you were going to split it. No rush at all, just wanted to make sure
> you weren't waiting for me.

What's the status for this? I really need to get this fixed.

[pbos-webrtc, 2015-10-05 09:37:35]

rebase + compile

[pbos-webrtc, 2015-10-05 09:37:45]

pbos@webrtc.org changed reviewers:
+ tina.legrand@webrtc.org

[pbos-webrtc, 2015-10-05 09:37:46]

+R tina.legrand (as root owner), since this is needed for the import it's more
urgent. I looked through all of talk/ and will continue looking further ahead.

[pbos-webrtc, 2015-10-05 10:09:02]

pbos@webrtc.org changed reviewers:
+ perkj@webrtc.org, pthatcher@webrtc.org, solenberg@webrtc.org,
stefan@webrtc.org

[pbos-webrtc, 2015-10-05 10:09:04]

Ok, here goes (PTAL, compiles OK). Motivation for doing this change: our
definitions of uint32 etc. clash with internal definitions when doing an import
of the codebase.

We use _t suffixes for most of the codebase, so we can be also be more
consistent by removing these.

I've split this up into several chunks so that every chunk is hopefully
manageable, there should be no functional changes (hence review is more
important than owner):

 talk/app/webrtc/  (+304,-296): perkj@
 talk/media/ (+1123, -1000): solenberg@
 talk/session/ (+578, -540): tina.legrand@
 webrtc/base/ (+1095, -1093): henrikg@
 webrtc/{examples,libjingle,modules,tools} (+159, -139): stefan@
 webrtc/p2p/ (+742, -694): pthatcher@
 webrtc/voice_engine/ (+11, -11): henrik.lundin@ (done!)
 webrtc/typedefs.h: tina.legrand@

[Henrik Grunell WebRTC, 2015-10-05 12:00:20]

https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/bitbuffer_uni...
File webrtc/base/bitbuffer_unittest.cc (right):

https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/bitbuffer_uni...
webrtc/base/bitbuffer_unittest.cc:57: const uint8_t bytes[] = {
Move { to line below.

https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/messagedigest.cc
File webrtc/base/messagedigest.cc (right):

https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/messagedigest...
webrtc/base/messagedigest.cc:130: i_pad(new uint8_t[block_len]);
Nit: I think it's more readable if
scoped_ptr<uint8_t[]> 
is on this line too.

https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/sha1.cc
File webrtc/base/sha1.cc (right):

https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/sha1.cc#newco...
webrtc/base/sha1.cc:78: * Change the typedef of uint32_t(8)_t to uint32_t(8). We
need this because in
Don't change the change log. :)

https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/sha1.cc#newco...
webrtc/base/sha1.cc:100: */
Add an entry here with your modification.

https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/testutils.h
File webrtc/base/testutils.h (right):

https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/testutils.h#n...
webrtc/base/testutils.h:551: BYTE_CAST(((uint32_t)x) >> 0),
BYTE_CAST(((uint32_t)x) >> 8), \
Nit: Fix indentation here and below. (2 chars)

[pbos-webrtc, 2015-10-05 12:19:54]

henrikg@ feedback

[pbos-webrtc, 2015-10-05 12:23:24]

PTAL :)

https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/bitbuffer_uni...
File webrtc/base/bitbuffer_unittest.cc (right):

https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/bitbuffer_uni...
webrtc/base/bitbuffer_unittest.cc:57: const uint8_t bytes[] = {
On 2015/10/05 12:00:19, Henrik Grunell (webrtc) wrote:
> Move { to line below.

Reformatted (clang-format).

https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/messagedigest.cc
File webrtc/base/messagedigest.cc (right):

https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/messagedigest...
webrtc/base/messagedigest.cc:130: i_pad(new uint8_t[block_len]);
On 2015/10/05 12:00:19, Henrik Grunell (webrtc) wrote:
> Nit: I think it's more readable if
> scoped_ptr<uint8_t[]> 
> is on this line too.

Agreed, it's also more style compliant. Done.

https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/sha1.cc
File webrtc/base/sha1.cc (right):

https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/sha1.cc#newco...
webrtc/base/sha1.cc:78: * Change the typedef of uint32_t(8)_t to uint32_t(8). We
need this because in
On 2015/10/05 12:00:19, Henrik Grunell (webrtc) wrote:
> Don't change the change log. :)

Oops, thanks!

https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/sha1.cc#newco...
webrtc/base/sha1.cc:100: */
On 2015/10/05 12:00:20, Henrik Grunell (webrtc) wrote:
> Add an entry here with your modification.

Done.

https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/testutils.h
File webrtc/base/testutils.h (right):

https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/testutils.h#n...
webrtc/base/testutils.h:551: BYTE_CAST(((uint32_t)x) >> 0),
BYTE_CAST(((uint32_t)x) >> 8), \
On 2015/10/05 12:00:19, Henrik Grunell (webrtc) wrote:
> Nit: Fix indentation here and below. (2 chars)

Formatted with clang-format, prefer not touching it. :)

[the sun, 2015-10-05 13:41:54]

On 2015/10/05 12:23:24, pbos-webrtc wrote:
> PTAL :)
> 
>
https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/bitbuffer_uni...
> File webrtc/base/bitbuffer_unittest.cc (right):
> 
>
https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/bitbuffer_uni...
> webrtc/base/bitbuffer_unittest.cc:57: const uint8_t bytes[] = {
> On 2015/10/05 12:00:19, Henrik Grunell (webrtc) wrote:
> > Move { to line below.
> 
> Reformatted (clang-format).
> 
>
https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/messagedigest.cc
> File webrtc/base/messagedigest.cc (right):
> 
>
https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/messagedigest...
> webrtc/base/messagedigest.cc:130: i_pad(new uint8_t[block_len]);
> On 2015/10/05 12:00:19, Henrik Grunell (webrtc) wrote:
> > Nit: I think it's more readable if
> > scoped_ptr<uint8_t[]> 
> > is on this line too.
> 
> Agreed, it's also more style compliant. Done.
> 
> https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/sha1.cc
> File webrtc/base/sha1.cc (right):
> 
>
https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/sha1.cc#newco...
> webrtc/base/sha1.cc:78: * Change the typedef of uint32_t(8)_t to uint32_t(8).
We
> need this because in
> On 2015/10/05 12:00:19, Henrik Grunell (webrtc) wrote:
> > Don't change the change log. :)
> 
> Oops, thanks!
> 
>
https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/sha1.cc#newco...
> webrtc/base/sha1.cc:100: */
> On 2015/10/05 12:00:20, Henrik Grunell (webrtc) wrote:
> > Add an entry here with your modification.
> 
> Done.
> 
> https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/testutils.h
> File webrtc/base/testutils.h (right):
> 
>
https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/testutils.h#n...
> webrtc/base/testutils.h:551: BYTE_CAST(((uint32_t)x) >> 0),
> BYTE_CAST(((uint32_t)x) >> 8), \
> On 2015/10/05 12:00:19, Henrik Grunell (webrtc) wrote:
> > Nit: Fix indentation here and below. (2 chars)
> 
> Formatted with clang-format, prefer not touching it. :)

LGTM for talk/media/.

[tlegrand-webrtc, 2015-10-05 13:49:01]

LG for talk/session - I added suggestions for cleaning up one of the files, but
feel free to leave it as it is.

webrtc/typedefs.h - I'm a bit confused over this change, since the comment says
"since pre-2010 MSVC doesn't provide stdint.h"

Will this compile on all platforms?

https://codereview.webrtc.org/1362503003/diff/50001/talk/session/media/planar...
File talk/session/media/planarfunctions_unittest.cc (right):

https://codereview.webrtc.org/1362503003/diff/50001/talk/session/media/planar...
talk/session/media/planarfunctions_unittest.cc:498: uint8_t* y_pointer = NULL, *
u_pointer = NULL, * v_pointer = NULL;
Can you rewrite this, so that each variable is declared separately?

https://codereview.webrtc.org/1362503003/diff/50001/talk/session/media/planar...
talk/session/media/planarfunctions_unittest.cc:534: uint8_t* y_pointer = NULL, *
u_pointer = NULL, * v_pointer = NULL;
Same as above.

https://codereview.webrtc.org/1362503003/diff/50001/talk/session/media/planar...
talk/session/media/planarfunctions_unittest.cc:553: * v_expected_pointer = NULL;
Again

https://codereview.webrtc.org/1362503003/diff/50001/talk/session/media/planar...
talk/session/media/planarfunctions_unittest.cc:600: * v_expected_pointer = NULL;
...and here.

https://codereview.webrtc.org/1362503003/diff/50001/talk/session/media/planar...
talk/session/media/planarfunctions_unittest.cc:624: uint8_t* y_pointer = NULL, *
uv_pointer = NULL;
Here

https://codereview.webrtc.org/1362503003/diff/50001/talk/session/media/planar...
talk/session/media/planarfunctions_unittest.cc:644: * v_expected_pointer = NULL;
Here

https://codereview.webrtc.org/1362503003/diff/50001/talk/session/media/planar...
talk/session/media/planarfunctions_unittest.cc:691: * v_expected_pointer = NULL;
                                    \
Declare separately.

https://codereview.webrtc.org/1362503003/diff/50001/talk/session/media/planar...
talk/session/media/planarfunctions_unittest.cc:708: }
Clang format here was unfortunate, since it's difficult to see the "real"
changes.

https://codereview.webrtc.org/1362503003/diff/50001/talk/session/media/planar...
talk/session/media/planarfunctions_unittest.cc:718: uint8_t* y_pointer = NULL, *
u_pointer = NULL, * v_pointer = NULL;         \
And here

https://codereview.webrtc.org/1362503003/diff/50001/talk/session/media/planar...
talk/session/media/planarfunctions_unittest.cc:761: uint8_t* y_pointer = NULL, *
u_pointer = NULL, * v_pointer = NULL;
Here

https://codereview.webrtc.org/1362503003/diff/50001/talk/session/media/planar...
talk/session/media/planarfunctions_unittest.cc:806: uint8_t* y_pointer = NULL, *
u_pointer = NULL, * v_pointer = NULL;
Here

https://codereview.webrtc.org/1362503003/diff/50001/webrtc/typedefs.h
File webrtc/typedefs.h (left):

https://codereview.webrtc.org/1362503003/diff/50001/webrtc/typedefs.h#oldcode68
webrtc/typedefs.h:68: // Define C99 equivalent types, since pre-2010 MSVC
doesn't provide stdint.h.
What happens if defined _MSC_VER?

[Henrik Grunell WebRTC, 2015-10-05 14:10:42]

I wonder how many
#include "webrtc/base/basictypes.h"
we can remove now? It would be really nice to do that - maybe in a follow-up CL.
I'm sure you're aware of tools for that, some examples in
http://stackoverflow.com/questions/614794/c-c-detecting-superfluous-includes

https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/testutils.h
File webrtc/base/testutils.h (right):

https://codereview.webrtc.org/1362503003/diff/40001/webrtc/base/testutils.h#n...
webrtc/base/testutils.h:551: BYTE_CAST(((uint32_t)x) >> 0),
BYTE_CAST(((uint32_t)x) >> 8), \
On 2015/10/05 12:23:23, pbos-webrtc wrote:
> On 2015/10/05 12:00:19, Henrik Grunell (webrtc) wrote:
> > Nit: Fix indentation here and below. (2 chars)
> 
> Formatted with clang-format, prefer not touching it. :)

Acknowledged.

https://codereview.webrtc.org/1362503003/diff/50001/webrtc/base/md5.h
File webrtc/base/md5.h (right):

https://codereview.webrtc.org/1362503003/diff/50001/webrtc/base/md5.h#newcode20
webrtc/base/md5.h:20: // Changes(hellner): added rtc namespace
Add change here.

https://codereview.webrtc.org/1362503003/diff/50001/webrtc/base/sha1.h
File webrtc/base/sha1.h (right):

https://codereview.webrtc.org/1362503003/diff/50001/webrtc/base/sha1.h#newcode13
webrtc/base/sha1.h:13: #include "webrtc/base/basictypes.h"
We shouldn't need this now, right? Update comment above if removed.

[perkj_webrtc, 2015-10-05 18:47:43]

talk/app/webrtc lgtm

What is the plan to prevent use of non _t types in the future if it actually is
a problem?

[pbos-webrtc, 2015-10-06 09:02:41]

rebase + tina's feedback

[pbos-webrtc, 2015-10-06 09:12:59]

henrikg feedback

[pbos-webrtc, 2015-10-06 09:15:00]

PTAL!

Tina: For Chromium MSVC >=2013 is required, and we've had stdint.h included
directly for years.

Per: Removing the uint32 etc. definitions, using them are compile errors now.

https://codereview.webrtc.org/1362503003/diff/50001/talk/session/media/planar...
File talk/session/media/planarfunctions_unittest.cc (right):

https://codereview.webrtc.org/1362503003/diff/50001/talk/session/media/planar...
talk/session/media/planarfunctions_unittest.cc:498: uint8_t* y_pointer = NULL, *
u_pointer = NULL, * v_pointer = NULL;
On 2015/10/05 13:49:01, tlegrand-webrtc wrote:
> Can you rewrite this, so that each variable is declared separately?

Done.

https://codereview.webrtc.org/1362503003/diff/50001/talk/session/media/planar...
talk/session/media/planarfunctions_unittest.cc:534: uint8_t* y_pointer = NULL, *
u_pointer = NULL, * v_pointer = NULL;
On 2015/10/05 13:49:01, tlegrand-webrtc wrote:
> Same as above.

Done.

https://codereview.webrtc.org/1362503003/diff/50001/talk/session/media/planar...
talk/session/media/planarfunctions_unittest.cc:553: * v_expected_pointer = NULL;
On 2015/10/05 13:49:01, tlegrand-webrtc wrote:
> Again

Done.

https://codereview.webrtc.org/1362503003/diff/50001/talk/session/media/planar...
talk/session/media/planarfunctions_unittest.cc:600: * v_expected_pointer = NULL;
On 2015/10/05 13:49:01, tlegrand-webrtc wrote:
> ...and here.

Done.

https://codereview.webrtc.org/1362503003/diff/50001/talk/session/media/planar...
talk/session/media/planarfunctions_unittest.cc:624: uint8_t* y_pointer = NULL, *
uv_pointer = NULL;
On 2015/10/05 13:49:01, tlegrand-webrtc wrote:
> Here

Done.

https://codereview.webrtc.org/1362503003/diff/50001/talk/session/media/planar...
talk/session/media/planarfunctions_unittest.cc:644: * v_expected_pointer = NULL;
On 2015/10/05 13:49:01, tlegrand-webrtc wrote:
> Here

Done.

https://codereview.webrtc.org/1362503003/diff/50001/talk/session/media/planar...
talk/session/media/planarfunctions_unittest.cc:691: * v_expected_pointer = NULL;
                                    \
On 2015/10/05 13:49:01, tlegrand-webrtc wrote:
> Declare separately.

Done.

https://codereview.webrtc.org/1362503003/diff/50001/talk/session/media/planar...
talk/session/media/planarfunctions_unittest.cc:708: }
On 2015/10/05 13:49:01, tlegrand-webrtc wrote:
> Clang format here was unfortunate, since it's difficult to see the "real"
> changes.

Acknowledged.

https://codereview.webrtc.org/1362503003/diff/50001/talk/session/media/planar...
talk/session/media/planarfunctions_unittest.cc:718: uint8_t* y_pointer = NULL, *
u_pointer = NULL, * v_pointer = NULL;         \
On 2015/10/05 13:49:01, tlegrand-webrtc wrote:
> And here

Done.

https://codereview.webrtc.org/1362503003/diff/50001/talk/session/media/planar...
talk/session/media/planarfunctions_unittest.cc:761: uint8_t* y_pointer = NULL, *
u_pointer = NULL, * v_pointer = NULL;
On 2015/10/05 13:49:01, tlegrand-webrtc wrote:
> Here

Done.

https://codereview.webrtc.org/1362503003/diff/50001/talk/session/media/planar...
talk/session/media/planarfunctions_unittest.cc:806: uint8_t* y_pointer = NULL, *
u_pointer = NULL, * v_pointer = NULL;
On 2015/10/05 13:49:01, tlegrand-webrtc wrote:
> Here

Done.

https://codereview.webrtc.org/1362503003/diff/50001/webrtc/base/md5.h
File webrtc/base/md5.h (right):

https://codereview.webrtc.org/1362503003/diff/50001/webrtc/base/md5.h#newcode20
webrtc/base/md5.h:20: // Changes(hellner): added rtc namespace
On 2015/10/05 14:10:42, Henrik Grunell (webrtc) wrote:
> Add change here.

Done + header revert.

https://codereview.webrtc.org/1362503003/diff/50001/webrtc/base/sha1.h
File webrtc/base/sha1.h (right):

https://codereview.webrtc.org/1362503003/diff/50001/webrtc/base/sha1.h#newcode13
webrtc/base/sha1.h:13: #include "webrtc/base/basictypes.h"
On 2015/10/05 14:10:42, Henrik Grunell (webrtc) wrote:
> We shouldn't need this now, right? Update comment above if removed.

Adding stdint.h/stdlib.h for the types and updating comment.

https://codereview.webrtc.org/1362503003/diff/50001/webrtc/typedefs.h
File webrtc/typedefs.h (left):

https://codereview.webrtc.org/1362503003/diff/50001/webrtc/typedefs.h#oldcode68
webrtc/typedefs.h:68: // Define C99 equivalent types, since pre-2010 MSVC
doesn't provide stdint.h.
On 2015/10/05 13:49:01, tlegrand-webrtc wrote:
> What happens if defined _MSC_VER?

It's fine, we include stdint.h from many other places directly in the code, so
we don't support a toolchain anymore where stdint.h isn't included (all MSVC
versions that we build on have it). :)

[stefan-webrtc, 2015-10-06 09:20:02]

lgtm

https://codereview.webrtc.org/1362503003/diff/70001/webrtc/examples/peerconne...
File webrtc/examples/peerconnection/client/linux/main_wnd.h (right):

https://codereview.webrtc.org/1362503003/diff/70001/webrtc/examples/peerconne...
webrtc/examples/peerconnection/client/linux/main_wnd.h:114:
rtc::scoped_ptr<uint8_t> draw_buffer_;
This looks weird... Please take a look.

[pbos-webrtc, 2015-10-06 09:27:10]

stefan@'s feedback

[pbos-webrtc, 2015-10-06 09:28:04]

https://codereview.webrtc.org/1362503003/diff/70001/webrtc/examples/peerconne...
File webrtc/examples/peerconnection/client/linux/main_wnd.h (right):

https://codereview.webrtc.org/1362503003/diff/70001/webrtc/examples/peerconne...
webrtc/examples/peerconnection/client/linux/main_wnd.h:114:
rtc::scoped_ptr<uint8_t> draw_buffer_;
On 2015/10/06 09:20:02, stefan-webrtc (holmer) wrote:
> This looks weird... Please take a look.

Eep, done.

[Henrik Grunell WebRTC, 2015-10-06 09:41:38]

webrtc/base lgtm

Great that you're doing this!

[pbos-webrtc, 2015-10-06 09:44:07]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-06 09:45:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1362503003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1362503003/80001

[commit-bot: I haz the power, 2015-10-06 09:49:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-06 09:49:58]

Dry run: Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1106)

[the sun, 2015-10-06 11:23:54]

https://codereview.webrtc.org/1362503003/diff/80001/webrtc/p2p/base/faketrans...
File webrtc/p2p/base/faketransportcontroller.h (left):

https://codereview.webrtc.org/1362503003/diff/80001/webrtc/p2p/base/faketrans...
webrtc/p2p/base/faketransportcontroller.h:325: IceRole role_ = ICEROLE_UNKNOWN;
Why aren't these needed anymore?

https://codereview.webrtc.org/1362503003/diff/80001/webrtc/p2p/base/p2ptransp...
File webrtc/p2p/base/p2ptransportchannel.cc (right):

https://codereview.webrtc.org/1362503003/diff/80001/webrtc/p2p/base/p2ptransp...
webrtc/p2p/base/p2ptransportchannel.cc:950: for (size_t i = 0; i <
connections_.size(); ++i) {
size_t here and uint32_t in other loops? Consistency please.

[pbos-webrtc, 2015-10-06 11:54:12]

solenberg: add back initializes + size_t for loops

[pbos-webrtc, 2015-10-06 11:55:12]

PTAL

(pthatcher@ FYI: solenberg@ is doing webrtc/p2p so we can get this in our TZ)

https://codereview.webrtc.org/1362503003/diff/80001/webrtc/p2p/base/faketrans...
File webrtc/p2p/base/faketransportcontroller.h (left):

https://codereview.webrtc.org/1362503003/diff/80001/webrtc/p2p/base/faketrans...
webrtc/p2p/base/faketransportcontroller.h:325: IceRole role_ = ICEROLE_UNKNOWN;
On 2015/10/06 11:23:53, the sun wrote:
> Why aren't these needed anymore?

Sorry, bad rebase. Added back, thanks.

https://codereview.webrtc.org/1362503003/diff/80001/webrtc/p2p/base/p2ptransp...
File webrtc/p2p/base/p2ptransportchannel.cc (right):

https://codereview.webrtc.org/1362503003/diff/80001/webrtc/p2p/base/p2ptransp...
webrtc/p2p/base/p2ptransportchannel.cc:950: for (size_t i = 0; i <
connections_.size(); ++i) {
On 2015/10/06 11:23:54, the sun wrote:
> size_t here and uint32_t in other loops? Consistency please.

Done.

[the sun, 2015-10-06 13:27:12]

LGTM for webrtc/p2p

[tlegrand-webrtc, 2015-10-07 09:35:33]

Thanks Peter! LGTM

[pbos-webrtc, 2015-10-07 09:58:01]

rebase + revert basictypes.h (to be landed separately just in case of a revert
due to unexpected uses)

[pbos-webrtc, 2015-10-07 10:23:40]

Committed patchset #11 (id:100001) manually as
0c4e06b4c6107a1b94f764e279e4fb4161e905b0 (presubmit successful).

[commit-bot: I haz the power, 2015-10-07 10:23:45]

Patchset 11 (id:??) landed as
https://crrev.com/0c4e06b4c6107a1b94f764e279e4fb4161e905b0
Cr-Commit-Position: refs/heads/master@{#10196}