webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc - Issue 1362503003: Use suffixed {uint,int}{8,16,32,64}_t types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc

Issue 1362503003: Use suffixed {uint,int}{8,16,32,64}_t types. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase + revert basictypes.h (to be landed separately just in case of a revert due to unexpected us… Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_decoder.cc ('k') | webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_nalu.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc

diff --git a/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc b/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc

index fec32261b767635b20f88e4337aa72d66fc31c80..69e52a5b2748f255c4871c94aabfc3a155145987 100644

--- a/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc

+++ b/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc

@@ -136,10 +136,10 @@ bool CopyVideoFrameToPixelBuffer(const webrtc::VideoFrame& frame,

LOG(LS_ERROR) << "Failed to lock base address: " << cvRet;

return false;

}

- uint8* dst_y = reinterpret_cast<uint8*>(

+ uint8_t* dst_y = reinterpret_cast<uint8_t*>(

CVPixelBufferGetBaseAddressOfPlane(pixel_buffer, 0));

int dst_stride_y = CVPixelBufferGetBytesPerRowOfPlane(pixel_buffer, 0);

- uint8* dst_uv = reinterpret_cast<uint8*>(

+ uint8_t* dst_uv = reinterpret_cast<uint8_t*>(

CVPixelBufferGetBaseAddressOfPlane(pixel_buffer, 1));

int dst_stride_uv = CVPixelBufferGetBytesPerRowOfPlane(pixel_buffer, 1);

// Convert I420 to NV12.