talk/app/webrtc/java/jni/androidmediadecoder_jni.cc - Issue 1362503003: Use suffixed {uint,int}{8,16,32,64}_t types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/java/jni/androidmediadecoder_jni.cc

Issue 1362503003: Use suffixed {uint,int}{8,16,32,64}_t types. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase + revert basictypes.h (to be landed separately just in case of a revert due to unexpected us… Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: talk/app/webrtc/java/jni/androidmediadecoder_jni.cc

diff --git a/talk/app/webrtc/java/jni/androidmediadecoder_jni.cc b/talk/app/webrtc/java/jni/androidmediadecoder_jni.cc

index f859410acb011ee137387610e814d1fdf71c268d..1f6313119e8d0d5b2726a75f38417102b5887147 100644

--- a/talk/app/webrtc/java/jni/androidmediadecoder_jni.cc

+++ b/talk/app/webrtc/java/jni/androidmediadecoder_jni.cc

@@ -519,10 +519,10 @@ int32_t MediaCodecVideoDecoder::DecodeOnCodecThread(

// Copy encoded data to Java ByteBuffer.

jobject j_input_buffer = input_buffers_[j_input_buffer_index];

- uint8* buffer =

- reinterpret_cast<uint8*>(jni->GetDirectBufferAddress(j_input_buffer));

+ uint8_t* buffer =

+ reinterpret_cast<uint8_t*>(jni->GetDirectBufferAddress(j_input_buffer));

RTC_CHECK(buffer) << "Indirect buffer??";

- int64 buffer_capacity = jni->GetDirectBufferCapacity(j_input_buffer);

+ int64_t buffer_capacity = jni->GetDirectBufferCapacity(j_input_buffer);

if (CheckException(jni) || buffer_capacity < inputImage._length) {

ALOGE("Input frame size %d is bigger than buffer size %d.",

inputImage._length, buffer_capacity);