Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Unified Diff: talk/session/media/channel.h

Issue 1362503003: Use suffixed {uint,int}{8,16,32,64}_t types. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase + revert basictypes.h (to be landed separately just in case of a revert due to unexpected us… Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/session/media/bundlefilter.cc ('k') | talk/session/media/channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/session/media/channel.h
diff --git a/talk/session/media/channel.h b/talk/session/media/channel.h
index 969f907928c5f6649bcbc0c6382b6d688d2d6a6f..c557ef35b58e7edb062bdd08698055247857b675 100644
--- a/talk/session/media/channel.h
+++ b/talk/session/media/channel.h
@@ -134,9 +134,9 @@ class BaseChannel
// Multiplexing
bool AddRecvStream(const StreamParams& sp);
- bool RemoveRecvStream(uint32 ssrc);
+ bool RemoveRecvStream(uint32_t ssrc);
bool AddSendStream(const StreamParams& sp);
- bool RemoveSendStream(uint32 ssrc);
+ bool RemoveSendStream(uint32_t ssrc);
// Monitoring
void StartConnectionMonitor(int cms);
@@ -226,9 +226,9 @@ class BaseChannel
void ChannelWritable_w();
void ChannelNotWritable_w();
bool AddRecvStream_w(const StreamParams& sp);
- bool RemoveRecvStream_w(uint32 ssrc);
+ bool RemoveRecvStream_w(uint32_t ssrc);
bool AddSendStream_w(const StreamParams& sp);
- bool RemoveSendStream_w(uint32 ssrc);
+ bool RemoveSendStream_w(uint32_t ssrc);
virtual bool ShouldSetupDtlsSrtp() const;
// Do the DTLS key expansion and impose it on the SRTP/SRTCP filters.
// |rtcp_channel| indicates whether to set up the RTP or RTCP filter.
@@ -335,11 +335,11 @@ class VoiceChannel : public BaseChannel {
bool rtcp);
~VoiceChannel();
bool Init();
- bool SetRemoteRenderer(uint32 ssrc, AudioRenderer* renderer);
+ bool SetRemoteRenderer(uint32_t ssrc, AudioRenderer* renderer);
// Configure sending media on the stream with SSRC |ssrc|
// If there is only one sending stream SSRC 0 can be used.
- bool SetAudioSend(uint32 ssrc,
+ bool SetAudioSend(uint32_t ssrc,
bool enable,
const AudioOptions* options,
AudioRenderer* renderer);
@@ -364,8 +364,8 @@ class VoiceChannel : public BaseChannel {
// The |ssrc| should be either 0 or a valid send stream ssrc.
// The valid value for the |event| are 0 which corresponding to DTMF
// event 0-9, *, #, A-D.
- bool InsertDtmf(uint32 ssrc, int event_code, int duration, int flags);
- bool SetOutputScaling(uint32 ssrc, double left, double right);
+ bool InsertDtmf(uint32_t ssrc, int event_code, int duration, int flags);
+ bool SetOutputScaling(uint32_t ssrc, double left, double right);
// Get statistics about the current media session.
bool GetStats(VoiceMediaInfo* stats);
@@ -401,8 +401,8 @@ class VoiceChannel : public BaseChannel {
ContentAction action,
std::string* error_desc);
void HandleEarlyMediaTimeout();
- bool InsertDtmf_w(uint32 ssrc, int event, int duration, int flags);
- bool SetOutputScaling_w(uint32 ssrc, double left, double right);
+ bool InsertDtmf_w(uint32_t ssrc, int event, int duration, int flags);
+ bool SetOutputScaling_w(uint32_t ssrc, double left, double right);
bool GetStats_w(VoiceMediaInfo* stats);
virtual void OnMessage(rtc::Message* pmsg);
@@ -443,20 +443,20 @@ class VideoChannel : public BaseChannel {
return static_cast<VideoMediaChannel*>(BaseChannel::media_channel());
}
- bool SetRenderer(uint32 ssrc, VideoRenderer* renderer);
+ bool SetRenderer(uint32_t ssrc, VideoRenderer* renderer);
bool ApplyViewRequest(const ViewRequest& request);
// TODO(pthatcher): Refactor to use a "capture id" instead of an
// ssrc here as the "key".
// Passes ownership of the capturer to the channel.
- bool AddScreencast(uint32 ssrc, VideoCapturer* capturer);
- bool SetCapturer(uint32 ssrc, VideoCapturer* capturer);
- bool RemoveScreencast(uint32 ssrc);
+ bool AddScreencast(uint32_t ssrc, VideoCapturer* capturer);
+ bool SetCapturer(uint32_t ssrc, VideoCapturer* capturer);
+ bool RemoveScreencast(uint32_t ssrc);
// True if we've added a screencast. Doesn't matter if the capturer
// has been started or not.
bool IsScreencasting();
- int GetScreencastFps(uint32 ssrc);
- int GetScreencastMaxPixels(uint32 ssrc);
+ int GetScreencastFps(uint32_t ssrc);
+ int GetScreencastMaxPixels(uint32_t ssrc);
// Get statistics about the current media session.
bool GetStats(VideoMediaInfo* stats);
@@ -466,17 +466,17 @@ class VideoChannel : public BaseChannel {
void StartMediaMonitor(int cms);
void StopMediaMonitor();
sigslot::signal2<VideoChannel*, const VideoMediaInfo&> SignalMediaMonitor;
- sigslot::signal2<uint32, rtc::WindowEvent> SignalScreencastWindowEvent;
+ sigslot::signal2<uint32_t, rtc::WindowEvent> SignalScreencastWindowEvent;
bool SendIntraFrame();
bool RequestIntraFrame();
// Configure sending media on the stream with SSRC |ssrc|
// If there is only one sending stream SSRC 0 can be used.
- bool SetVideoSend(uint32 ssrc, bool enable, const VideoOptions* options);
+ bool SetVideoSend(uint32_t ssrc, bool enable, const VideoOptions* options);
private:
- typedef std::map<uint32, VideoCapturer*> ScreencastMap;
+ typedef std::map<uint32_t, VideoCapturer*> ScreencastMap;
struct ScreencastDetailsData;
// overrides from BaseChannel
@@ -490,9 +490,9 @@ class VideoChannel : public BaseChannel {
std::string* error_desc);
bool ApplyViewRequest_w(const ViewRequest& request);
- bool AddScreencast_w(uint32 ssrc, VideoCapturer* capturer);
- bool RemoveScreencast_w(uint32 ssrc);
- void OnScreencastWindowEvent_s(uint32 ssrc, rtc::WindowEvent we);
+ bool AddScreencast_w(uint32_t ssrc, VideoCapturer* capturer);
+ bool RemoveScreencast_w(uint32_t ssrc);
+ void OnScreencastWindowEvent_s(uint32_t ssrc, rtc::WindowEvent we);
bool IsScreencasting_w() const;
void GetScreencastDetails_w(ScreencastDetailsData* d) const;
bool GetStats_w(VideoMediaInfo* stats);
@@ -503,10 +503,9 @@ class VideoChannel : public BaseChannel {
ConnectionMonitor* monitor, const std::vector<ConnectionInfo>& infos);
virtual void OnMediaMonitorUpdate(
VideoMediaChannel* media_channel, const VideoMediaInfo& info);
- virtual void OnScreencastWindowEvent(uint32 ssrc,
- rtc::WindowEvent event);
+ virtual void OnScreencastWindowEvent(uint32_t ssrc, rtc::WindowEvent event);
virtual void OnStateChange(VideoCapturer* capturer, CaptureState ev);
- bool GetLocalSsrc(const VideoCapturer* capturer, uint32* ssrc);
+ bool GetLocalSsrc(const VideoCapturer* capturer, uint32_t* ssrc);
VideoRenderer* renderer_;
ScreencastMap screencast_capturers_;
@@ -548,16 +547,14 @@ class DataChannel : public BaseChannel {
sigslot::signal2<DataChannel*, const DataMediaInfo&> SignalMediaMonitor;
sigslot::signal2<DataChannel*, const std::vector<ConnectionInfo>&>
SignalConnectionMonitor;
- sigslot::signal3<DataChannel*,
- const ReceiveDataParams&,
- const rtc::Buffer&>
+ sigslot::signal3<DataChannel*, const ReceiveDataParams&, const rtc::Buffer&>
SignalDataReceived;
// Signal for notifying when the channel becomes ready to send data.
// That occurs when the channel is enabled, the transport is writable,
// both local and remote descriptions are set, and the channel is unblocked.
sigslot::signal1<bool> SignalReadyToSendData;
// Signal for notifying that the remote side has closed the DataChannel.
- sigslot::signal1<uint32> SignalStreamClosedRemotely;
+ sigslot::signal1<uint32_t> SignalStreamClosedRemotely;
protected:
// downcasts a MediaChannel.
@@ -626,9 +623,9 @@ class DataChannel : public BaseChannel {
virtual bool ShouldSetupDtlsSrtp() const;
void OnDataReceived(
const ReceiveDataParams& params, const char* data, size_t len);
- void OnDataChannelError(uint32 ssrc, DataMediaChannel::Error error);
+ void OnDataChannelError(uint32_t ssrc, DataMediaChannel::Error error);
void OnDataChannelReadyToSend(bool writable);
- void OnStreamClosedRemotely(uint32 sid);
+ void OnStreamClosedRemotely(uint32_t sid);
rtc::scoped_ptr<DataMediaMonitor> media_monitor_;
// TODO(pthatcher): Make a separate SctpDataChannel and
« no previous file with comments | « talk/session/media/bundlefilter.cc ('k') | talk/session/media/channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698