audio_processing: Create now returns a pointer to the object

audio_processing: Create now returns a pointer to the object

Affects
* NS
* AGC
* AEC

BUG=webrtc:441
TESTED=locally on Linux and trybots
R=kwiberg@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/9345e86551a0e59e77dfee6eed3e2fe2a833b269

[bjornv1, 2015-06-10 08:19:39]

bjornv@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[bjornv1, 2015-06-10 09:14:07]

Care to take a look, Karl?

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/agc/legacy/analog_agc.c (right):

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/agc/legacy/analog_agc.c:1317: LegacyAgc* stt =
(LegacyAgc*)malloc(sizeof(LegacyAgc));
Is it really necessary to cast here?

[kwiberg-webrtc, 2015-06-10 09:31:44]

lgtm

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/aec/aec_core.c (right):

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/aec/aec_core.c:1375: }
I'm pretty sure we could just assert that all of these allocations succeed, but
that's another CL...

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/aec/aec_core.h (right):

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/aec/aec_core.h:54: AecCore*
WebRtcAec_CreateAec();
A comment that it returns NULL on error?

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/aec/aec_resampler.h (right):

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/aec/aec_resampler.h:24: void*
WebRtcAec_CreateResampler();
An otherwise specification that it returns NULL on error?

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/aec/echo_cancellation_unittest.cc (right):

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/aec/echo_cancellation_unittest.cc:29:
CHECK(handle != nullptr);
This is in a test, so

  ASSERT_TRUE(handle);

?

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/aec/echo_cancellation_unittest.cc:36:
CHECK(handle != nullptr);
Same.

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/aec/include/echo_cancellation.h (right):

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/aec/include/echo_cancellation.h:68: * object.
Or NULL on error.

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/aec/system_delay_unittest.cc (right):

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/aec/system_delay_unittest.cc:72: CHECK(handle_
!= nullptr);
ASSERT_TRUE?

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/agc/legacy/analog_agc.c (right):

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/agc/legacy/analog_agc.c:1317: LegacyAgc* stt =
(LegacyAgc*)malloc(sizeof(LegacyAgc));
On 2015/06/10 at 09:14:06, bjornv1 wrote:
> Is it really necessary to cast here?

No. Unlike C++, C will implicitly cast void* to any pointer type. (Both of them
will implicitly cast any pointer type to void*.)

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/ns/include/noise_suppression.h (right):

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/ns/include/noise_suppression.h:23: * This
function creates an instance to the floating point Noise Suppression.
and instance *of*

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/ns/include/noise_suppression_x.h (right):

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/ns/include/noise_suppression_x.h:23: * This
function creates an instance to the fixed point Noise Suppression.
of

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/ns/noise_suppression.c (right):

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/ns/noise_suppression.c:21: NoiseSuppressionC*
self = malloc(sizeof(NoiseSuppressionC));
See? No cast.

[bjornv1, 2015-06-10 19:03:04]

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/aec/aec_core.c (right):

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/aec/aec_core.c:1375: }
On 2015/06/10 at 09:31:43, kwiberg1 wrote:
> I'm pretty sure we could just assert that all of these allocations succeed,
but that's another CL...

Agree

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/aec/aec_core.h (right):

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/aec/aec_core.h:54: AecCore*
WebRtcAec_CreateAec();
On 2015/06/10 at 09:31:43, kwiberg1 wrote:
> A comment that it returns NULL on error?

Done

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/aec/aec_resampler.h (right):

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/aec/aec_resampler.h:24: void*
WebRtcAec_CreateResampler();
On 2015/06/10 at 09:31:43, kwiberg1 wrote:
> An otherwise specification that it returns NULL on error?

Done

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/aec/echo_cancellation_unittest.cc (right):

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/aec/echo_cancellation_unittest.cc:29:
CHECK(handle != nullptr);
On 2015/06/10 at 09:31:43, kwiberg1 wrote:
> This is in a test, so
> 
>   ASSERT_TRUE(handle);
> 
> ?

Done

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/aec/echo_cancellation_unittest.cc:36:
CHECK(handle != nullptr);
On 2015/06/10 at 09:31:43, kwiberg1 wrote:
> Same.

Done

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/aec/include/echo_cancellation.h (right):

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/aec/include/echo_cancellation.h:68: * object.
On 2015/06/10 at 09:31:43, kwiberg1 wrote:
> Or NULL on error.

Done

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/aec/system_delay_unittest.cc (right):

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/aec/system_delay_unittest.cc:72: CHECK(handle_
!= nullptr);
On 2015/06/10 at 09:31:43, kwiberg1 wrote:
> ASSERT_TRUE?

Done

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/ns/include/noise_suppression.h (right):

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/ns/include/noise_suppression.h:23: * This
function creates an instance to the floating point Noise Suppression.
On 2015/06/10 at 09:31:43, kwiberg1 wrote:
> and instance *of*

Done

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/ns/include/noise_suppression_x.h (right):

https://codereview.webrtc.org/1175903002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/ns/include/noise_suppression_x.h:23: * This
function creates an instance to the fixed point Noise Suppression.
On 2015/06/10 at 09:31:43, kwiberg1 wrote:
> of

Done

[kwiberg-webrtc, 2015-06-10 19:13:42]

more lgtm

[bjornv1, 2015-06-10 19:43:51]

Committed patchset #2 (id:20001) manually as
9345e86551a0e59e77dfee6eed3e2fe2a833b269 (presubmit successful).