webrtc/modules/audio_processing/noise_suppression_impl.cc - Issue 1175903002: audio_processing: Create now returns a pointer to the object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/noise_suppression_impl.cc

Issue 1175903002: audio_processing: Create now returns a pointer to the object (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Addressed review comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_processing/gain_control_impl.cc ('k') | webrtc/modules/audio_processing/ns/include/noise_suppression.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/noise_suppression_impl.cc

diff --git a/webrtc/modules/audio_processing/noise_suppression_impl.cc b/webrtc/modules/audio_processing/noise_suppression_impl.cc

index aa37e67fa819f2f4207a757ee51adf3af81fb35d..15019112647efa1b02a15d65401b5499f21e670d 100644

--- a/webrtc/modules/audio_processing/noise_suppression_impl.cc

+++ b/webrtc/modules/audio_processing/noise_suppression_impl.cc

@@ -134,19 +134,11 @@ float NoiseSuppressionImpl::speech_probability() const {

}

void* NoiseSuppressionImpl::CreateHandle() const {

- Handle* handle = NULL;

#if defined(WEBRTC_NS_FLOAT)

- if (WebRtcNs_Create(&handle) != apm_->kNoError)

+ return WebRtcNs_Create();

#elif defined(WEBRTC_NS_FIXED)

- if (WebRtcNsx_Create(&handle) != apm_->kNoError)

+ return WebRtcNsx_Create();

#endif

- {

- handle = NULL;

- } else {

- assert(handle != NULL);

- }

- return handle;

}

void NoiseSuppressionImpl::DestroyHandle(void* handle) const {