webrtc/modules/audio_processing/ns/include/noise_suppression.h - Issue 1175903002: audio_processing: Create now returns a pointer to the object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/ns/include/noise_suppression.h

Issue 1175903002: audio_processing: Create now returns a pointer to the object (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Addressed review comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_processing/noise_suppression_impl.cc ('k') | webrtc/modules/audio_processing/ns/include/noise_suppression_x.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/ns/include/noise_suppression.h

diff --git a/webrtc/modules/audio_processing/ns/include/noise_suppression.h b/webrtc/modules/audio_processing/ns/include/noise_suppression.h

index 14e686a8e393c5fad3335f32be0dce94c1b46587..41bf9aca41bb30c479bc1a0335a27137a7c95a8c 100644

--- a/webrtc/modules/audio_processing/ns/include/noise_suppression.h

+++ b/webrtc/modules/audio_processing/ns/include/noise_suppression.h

@@ -20,20 +20,9 @@ extern "C" {

#endif

- * This function creates an instance to the noise suppression structure

- *

- * Input:

- * - NS_inst : Pointer to noise suppression instance that should be

- * created

- *

- * Output:

- * - NS_inst : Pointer to created noise suppression instance

- *

- * Return value : 0 - Ok

- * -1 - Error

+ * This function creates an instance of the floating point Noise Suppression.

-int WebRtcNs_Create(NsHandle** NS_inst);

+NsHandle* WebRtcNs_Create();

* This function frees the dynamic memory of a specified noise suppression