webrtc/modules/audio_processing/agc/legacy/gain_control.h - Issue 1175903002: audio_processing: Create now returns a pointer to the object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/agc/legacy/gain_control.h

Issue 1175903002: audio_processing: Create now returns a pointer to the object (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Addressed review comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_processing/agc/legacy/analog_agc.c ('k') | webrtc/modules/audio_processing/echo_cancellation_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/agc/legacy/gain_control.h

diff --git a/webrtc/modules/audio_processing/agc/legacy/gain_control.h b/webrtc/modules/audio_processing/agc/legacy/gain_control.h

index 3994f55e8654f106f56dfdb908d8a8c53ca2c856..0ccba76c4bc5475fe714b87fdac91d8ed80bc0e6 100644

--- a/webrtc/modules/audio_processing/agc/legacy/gain_control.h

+++ b/webrtc/modules/audio_processing/agc/legacy/gain_control.h

@@ -200,13 +200,10 @@ int WebRtcAgc_set_config(void* agcInst, WebRtcAgcConfig config);

int WebRtcAgc_get_config(void* agcInst, WebRtcAgcConfig* config);

- * This function creates an AGC instance, which will contain the state

- * information for one (duplex) channel.

- *

- * Return value : AGC instance if successful

- * : 0 (i.e., a NULL pointer) if unsuccessful

+ * This function creates and returns an AGC instance, which will contain the

+ * state information for one (duplex) channel.

-int WebRtcAgc_Create(void **agcInst);

+void* WebRtcAgc_Create();

* This function frees the AGC instance created at the beginning.