audio_processing: Create now returns a pointer to the object

webrtc/modules/audio_processing/aec/echo_cancellation.c

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 100 matching lines @@
                          int16_t reported_delay_ms,
                          int32_t skew);
 static void ProcessExtended(Aec* self,
                             const float* const* near,
                             int num_bands,
                             float* const* out,
                             int16_t num_samples,
                             int16_t reported_delay_ms,
                             int32_t skew);
 
-int32_t WebRtcAec_Create(void** aecInst) {
-  Aec* aecpc;
-  if (aecInst == NULL) {
-    return -1;
+void* WebRtcAec_Create() {
+  Aec* aecpc = malloc(sizeof(Aec));
+
+  if (!aecpc) {
+    return NULL;
   }
 
-  aecpc = malloc(sizeof(Aec));
-  *aecInst = aecpc;
-  if (aecpc == NULL) {
-    return -1;
+  aecpc->aec = WebRtcAec_CreateAec();
+  if (!aecpc->aec) {
+    WebRtcAec_Free(aecpc);
+    return NULL;
   }
-
-  if (WebRtcAec_CreateAec(&aecpc->aec) == -1) {
+  aecpc->resampler = WebRtcAec_CreateResampler();
+  if (!aecpc->resampler) {
     WebRtcAec_Free(aecpc);
-    aecpc = NULL;
-    return -1;
-  }
-
-  if (WebRtcAec_CreateResampler(&aecpc->resampler) == -1) {
-    WebRtcAec_Free(aecpc);
-    aecpc = NULL;
-    return -1;
+    return NULL;
   }
   // Create far-end pre-buffer. The buffer size has to be large enough for
   // largest possible drift compensation (kResamplerBufferSize) + "almost" an
   // FFT buffer (PART_LEN2 - 1).
   aecpc->far_pre_buf =
       WebRtc_CreateBuffer(PART_LEN2 + kResamplerBufferSize, sizeof(float));
   if (!aecpc->far_pre_buf) {
     WebRtcAec_Free(aecpc);
-    aecpc = NULL;
-    return -1;
+    return NULL;
   }
 
   aecpc->initFlag = 0;
   aecpc->lastError = 0;
 
 #ifdef WEBRTC_AEC_DEBUG_DUMP
   {
     char filename[64];
     sprintf(filename, "aec_buf%d.dat", webrtc_aec_instance_count);
     aecpc->bufFile = fopen(filename, "wb");
     sprintf(filename, "aec_skew%d.dat", webrtc_aec_instance_count);
     aecpc->skewFile = fopen(filename, "wb");
     sprintf(filename, "aec_delay%d.dat", webrtc_aec_instance_count);
     aecpc->delayFile = fopen(filename, "wb");
     webrtc_aec_instance_count++;
   }
 #endif
 
-  return 0;
+  return aecpc;
 }
 
 void WebRtcAec_Free(void* aecInst) {
   Aec* aecpc = aecInst;
 
   if (aecpc == NULL) {
     return;
   }
 
   WebRtc_FreeBuffer(aecpc->far_pre_buf);
@@ skipping 739 matching lines @@
     }
   } else {
     self->timeForDelayChange = 0;
   }
   self->lastDelayDiff = delay_difference;
 
   if (self->timeForDelayChange > 25) {
     self->knownDelay = WEBRTC_SPL_MAX((int)self->filtDelay - 256, 0);
   }
 }