webrtc/modules/audio_processing/aec/echo_cancellation_unittest.cc - Issue 1175903002: audio_processing: Create now returns a pointer to the object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/aec/echo_cancellation_unittest.cc

Issue 1175903002: audio_processing: Create now returns a pointer to the object (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Addressed review comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_processing/aec/echo_cancellation.c ('k') | webrtc/modules/audio_processing/aec/include/echo_cancellation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/aec/echo_cancellation_unittest.cc

diff --git a/webrtc/modules/audio_processing/aec/echo_cancellation_unittest.cc b/webrtc/modules/audio_processing/aec/echo_cancellation_unittest.cc

index 6c325e0c518174c16a6b7cd83b7c938772169503..315ac3e9f95ffbdf6bb75535c048645cf7a24c32 100644

--- a/webrtc/modules/audio_processing/aec/echo_cancellation_unittest.cc

+++ b/webrtc/modules/audio_processing/aec/echo_cancellation_unittest.cc

@@ -20,22 +20,20 @@ extern "C" {

}

#include "testing/gtest/include/gtest/gtest.h"

+#include "webrtc/base/checks.h"

namespace webrtc {

TEST(EchoCancellationTest, CreateAndFreeHasExpectedBehavior) {

- EXPECT_EQ(-1, WebRtcAec_Create(NULL));

- void* handle = NULL;

- ASSERT_EQ(0, WebRtcAec_Create(&handle));

- EXPECT_TRUE(handle != NULL);

+ void* handle = WebRtcAec_Create();

+ ASSERT_TRUE(handle);

WebRtcAec_Free(nullptr);

WebRtcAec_Free(handle);

}

TEST(EchoCancellationTest, ApplyAecCoreHandle) {

- void* handle = NULL;

- ASSERT_EQ(0, WebRtcAec_Create(&handle));

- EXPECT_TRUE(handle != NULL);

+ void* handle = WebRtcAec_Create();

+ ASSERT_TRUE(handle);

EXPECT_TRUE(WebRtcAec_aec_core(NULL) == NULL);

AecCore* aec_core = WebRtcAec_aec_core(handle);

EXPECT_TRUE(aec_core != NULL);