webrtc/modules/audio_processing/aec/include/echo_cancellation.h - Issue 1175903002: audio_processing: Create now returns a pointer to the object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/aec/include/echo_cancellation.h

Issue 1175903002: audio_processing: Create now returns a pointer to the object (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Addressed review comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_processing/aec/echo_cancellation_unittest.cc ('k') | webrtc/modules/audio_processing/aec/system_delay_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/aec/include/echo_cancellation.h

diff --git a/webrtc/modules/audio_processing/aec/include/echo_cancellation.h b/webrtc/modules/audio_processing/aec/include/echo_cancellation.h

index 6914ed1a9e77971df3f596aa030ab58a1aa72845..e49a0847e03a96630479f24bedd5559aae651441 100644

--- a/webrtc/modules/audio_processing/aec/include/echo_cancellation.h

+++ b/webrtc/modules/audio_processing/aec/include/echo_cancellation.h

@@ -64,19 +64,10 @@ extern "C" {

* Allocates the memory needed by the AEC. The memory needs to be initialized

- * separately using the WebRtcAec_Init() function.

- *

- * Inputs Description

- * -------------------------------------------------------------------

- * void** aecInst Pointer to the AEC instance to be created

- * and initialized

- *

- * Outputs Description

- * -------------------------------------------------------------------

- * int32_t return 0: OK

- * -1: error

+ * separately using the WebRtcAec_Init() function. Returns a pointer to the

+ * object or NULL on error.

-int32_t WebRtcAec_Create(void** aecInst);

+void* WebRtcAec_Create();

* This function releases the memory allocated by WebRtcAec_Create().