Add logging of host lookups made by TurnPort to the RtcEventLog.

Add logging host lookups made by TurnPort to the RtcEventLog.

The following fields are logged:
- error, if there was an error.
- elapsed time in milliseconds

BUG=webrtc:8100
Review-Url: https://codereview.webrtc.org/2996933003
Cr-Commit-Position: refs/heads/master@{#19574}
Committed: https://chromium.googlesource.com/external/webrtc/+/c251cb13c08aba710ba3a12588beb4aa172c7323

[jonaso, 2017-08-15 13:33:24]

The CQ bit was checked by jonaso@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-15 13:33:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-15 13:36:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-15 13:36:27]

Dry run: Try jobs failed on following builders:
  linux_gcc_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_gcc_rel/builds/1311)
  mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)

[jonaso, 2017-08-15 13:53:24]

The CQ bit was checked by jonaso@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-15 13:53:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-15 14:09:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-15 14:09:07]

Dry run: Try jobs failed on following builders:
  mac_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/27037)

[jonaso, 2017-08-16 07:27:20]

The CQ bit was checked by jonaso@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-16 07:27:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-16 07:32:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-16 07:32:57]

Dry run: Try jobs failed on following builders:
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/22816)

[jonaso, 2017-08-16 07:59:52]

The CQ bit was checked by jonaso@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-16 07:59:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-16 09:16:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-16 09:16:52]

Dry run: This issue passed the CQ dry run.

[jonaso, 2017-08-16 12:01:08]

The CQ bit was checked by jonaso@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-16 12:01:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[jonaso1, 2017-08-16 12:03:57]

Description was changed from

==========
Add logging host lookups made by TurnPort to the RtcEventLog.

The following fields are logged:
- hostname, that is being looked up.
- error, if there was an error.
- resulting IP (if a entry found)
- elapsed time in microseconds.

BUG=webrtc:8100
==========

to

==========
Add logging host lookups made by TurnPort to the RtcEventLog.

The following fields are logged:
- hostname, that is being looked up.
- error, if there was an error.
- resulting IP (if a entry found)
- elapsed time in microseconds.

BUG=webrtc:8100
==========

[jonaso1, 2017-08-16 12:03:57]

jonaso@google.com changed reviewers:
+ pthatcher@webrtc.org, terelius@webrtc.org

[commit-bot: I haz the power, 2017-08-16 13:50:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-16 13:50:33]

Dry run: This issue passed the CQ dry run.

[jonaso1, 2017-08-16 13:55:17]

jonaso@google.com changed reviewers:
+ jonaso@google.com

[terelius, 2017-08-16 14:19:07]

I think we need to have a meeting to discuss these changes. 

FYI, we're currently working on a complete rewrite of the event log.

https://codereview.webrtc.org/2996933003/diff/80001/webrtc/logging/rtc_event_...
File webrtc/logging/rtc_event_log/rtc_event_log.proto (right):

https://codereview.webrtc.org/2996933003/diff/80001/webrtc/logging/rtc_event_...
webrtc/logging/rtc_event_log/rtc_event_log.proto:324: optional string hostname =
1;
Generally speaking, we don't want to have strings in the proto. Is this really
necessary?

https://codereview.webrtc.org/2996933003/diff/80001/webrtc/logging/rtc_event_...
webrtc/logging/rtc_event_log/rtc_event_log.proto:330: optional string
lookup_result = 3;
Same here. How do we guarantee anonymization?

https://codereview.webrtc.org/2996933003/diff/80001/webrtc/logging/rtc_event_...
webrtc/logging/rtc_event_log/rtc_event_log.proto:333: optional int64
elapsed_time_in_microseconds = 4;
Is microsecond accuracy needed here?

[pthatcher, 2017-08-16 23:23:49]

pthatcher@google.com changed reviewers:
+ pthatcher@google.com

[pthatcher, 2017-08-16 23:23:50]

I recall that we tried using RtcEventLog within in the p2p directory about 6-12
months ago and had lots of problems.  I thought we eventually gave up, but I
could be wrong.

Also, we have a plan on my team to replace the WebRTC unstructured logging with
a semi-structured logging.  If you're planning on replacing RtcEventLogs (our
structured logging), you might consider that plan as well.  Maybe we could end
up with one logging system.

[jonaso, 2017-08-18 07:14:17]

The CQ bit was checked by jonaso@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-18 07:14:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-18 07:50:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-18 07:50:18]

Dry run: This issue passed the CQ dry run.

[jonaso1, 2017-08-18 08:29:06]

PTAL
- strings removed from proto
- resolution lowered to millis

- regarding using RtcEventLog from p2p:
  this seems to be working fine as long as we don't introduce new dependencies
to RtcEventLog.

[terelius, 2017-08-18 11:41:33]

Could you also update rtc_event_log2text please?

looks good, but someone more familiar with the p2p code needs to look at that
part. Some other comments below:

https://codereview.webrtc.org/2996933003/diff/100001/webrtc/logging/rtc_event...
File webrtc/logging/rtc_event_log/rtc_event_log.proto (right):

https://codereview.webrtc.org/2996933003/diff/100001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log.proto:327: optional int64
elapsed_time_in_milliseconds = 2;
I'd prefer elapsed_time_ms or (maybe even better) host_lookup_time_ms.

https://codereview.webrtc.org/2996933003/diff/100001/webrtc/logging/rtc_event...
File webrtc/logging/rtc_event_log/rtc_event_log_parser.cc (right):

https://codereview.webrtc.org/2996933003/diff/100001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log_parser.cc:647: 
You might want to add a method to parse the data e.g.
HostLookupResult ParsedRtcEventLog::GetHostLookupResult(size_t index);

https://codereview.webrtc.org/2996933003/diff/100001/webrtc/logging/rtc_event...
File webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc (right):

https://codereview.webrtc.org/2996933003/diff/100001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc:917: //
RtcEventLogTestHelper::VerifyLogHostLookupEvent(parsed_log, 1);
Uncomment this?

https://codereview.webrtc.org/2996933003/diff/100001/webrtc/logging/rtc_event...
File webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc (right):

https://codereview.webrtc.org/2996933003/diff/100001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc:573: void
RtcEventLogTestHelper::VerifyLogHostLookupEvent(
You should also test that the error code and elapsed_time are written correctly.
If you add a method to the parser, e.g. GetHostLookup(size_t index, int* error,
int64_t* elapsed_time),  then you might want to also test the consistency of
that here.

https://codereview.webrtc.org/2996933003/diff/100001/webrtc/p2p/base/port_uni...
File webrtc/p2p/base/port_unittest.cc (right):

https://codereview.webrtc.org/2996933003/diff/100001/webrtc/p2p/base/port_uni...
webrtc/p2p/base/port_unittest.cc:536: uint16_t min_port = 0;
Should these be const?
Maybe constexpr uint16_t kMinPort = 0; ?

https://codereview.webrtc.org/2996933003/diff/100001/webrtc/voice_engine/chan...
File webrtc/voice_engine/channel.cc (right):

https://codereview.webrtc.org/2996933003/diff/100001/webrtc/voice_engine/chan...
webrtc/voice_engine/channel.cc:191: RTC_NOTREACHED();
The rest of the code has forwarded the call, regardless of whether the function
is expected to be called via the voice engine or not. On the other hand, it
makes sense to catch unexpected calls. One of the owners need to decide what the
policy should be here.

[jonaso, 2017-08-21 06:37:55]

The CQ bit was checked by jonaso@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-21 06:38:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-21 06:46:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-21 06:46:11]

Dry run: Try jobs failed on following builders:
  ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/buil...)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/22980)

[jonaso, 2017-08-21 06:53:20]

The CQ bit was checked by jonaso@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-21 06:53:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-21 07:22:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-21 07:22:02]

Dry run: Try jobs failed on following builders:
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/28303)

[jonaso, 2017-08-21 07:29:45]

The CQ bit was checked by jonaso@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-21 07:29:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-21 08:15:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-21 08:15:22]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[jonaso1, 2017-08-21 08:22:35]

Thanks for review.
Fixed review comments.
PTAL

[terelius, 2017-08-21 09:38:14]

https://codereview.webrtc.org/2996933003/diff/160001/webrtc/logging/rtc_event...
File webrtc/logging/rtc_event_log/rtc_event_log.cc (right):

https://codereview.webrtc.org/2996933003/diff/160001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log.cc:573: int64_t
elapsed_time_in_milliseconds) {
nit: I'd prefer changing this to "host_lookup_time_ms" too.

https://codereview.webrtc.org/2996933003/diff/160001/webrtc/logging/rtc_event...
File webrtc/logging/rtc_event_log/rtc_event_log_parser.cc (right):

https://codereview.webrtc.org/2996933003/diff/160001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log_parser.cc:670: *error =
lookup_event.error();
We have previously allowed passing in nullptr if we're not interested in
particular field. I suggest changing to
if (error)
  *error = lookup_event.error();

https://codereview.webrtc.org/2996933003/diff/160001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log_parser.cc:672: *host_lookup_time_ms =
lookup_event.host_lookup_time_ms();
Same here.

https://codereview.webrtc.org/2996933003/diff/160001/webrtc/logging/rtc_event...
File webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc (right):

https://codereview.webrtc.org/2996933003/diff/160001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc:586:
ASSERT_EQ(lookup_event.host_lookup_time_ms(), host_lookup_time_ms);
In addition to this code, could you also read the error and lookup_time using
the parser?

[jonaso, 2017-08-21 10:25:12]

The CQ bit was checked by jonaso@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-21 10:25:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-21 11:24:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-21 11:24:52]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[jonaso1, 2017-08-21 11:26:50]

thx again,
comments addressed.
PTAL

[terelius, 2017-08-21 11:41:54]

lgtm

An owner need to make a policy decision for the proxy object in channel.cc.

For the future, we normally mark the each comment as resolved by responding
"done".

[jonaso1, 2017-08-21 11:50:36]

jonaso@google.com changed reviewers:
+ solenberg@webrtc.org

[jonaso1, 2017-08-21 11:50:37]

Hi solenberg@

Do you care top chip in regarding my (minor) modifications
to webrtc/voice_engine/channel.cc

Thx!

/Jonas

[the sun, 2017-08-22 11:27:13]

On 2017/08/21 11:50:37, jonaso1 wrote:
> Hi solenberg@
> 
> Do you care top chip in regarding my (minor) modifications
> to webrtc/voice_engine/channel.cc
> 
> Thx!
> 
> /Jonas

terelius@: not all calls are forwarded by the proxy (e.g.
LogVideoReceiveStreamConfig and LogVideoSendStreamConfig are not). I suggest we
stick to that policy and keep the RTC_NOTREACHED().

lgtm for voice_engine/

[jonaso1, 2017-08-25 09:09:40]

The CQ bit was checked by jonaso@google.com

[commit-bot: I haz the power, 2017-08-25 09:09:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-25 09:13:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-25 09:13:58]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/20716)

[jonaso1, 2017-08-25 11:38:02]

Hi pthatcher,

I have now gotten LGTM from the other persons
affected by this.

Would you care to have a look ?
(or suggest someone else that I can ask)

/Jonas

[pthatcher1, 2017-08-26 05:11:27]

pthatcher@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[Taylor Brandstetter, 2017-08-29 02:30:56]

lgtm with nits

https://codereview.webrtc.org/2996933003/diff/180001/webrtc/logging/rtc_event...
File webrtc/logging/rtc_event_log/rtc_event_log.h (right):

https://codereview.webrtc.org/2996933003/diff/180001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log.h:174: virtual void
LogHostLookupResult(int error,
Can this comment document what "error" is? It looks like it's 0 on success, -1
on generic failure or "no address available for desired address family", and
otherwise is a "getaddrinfo" error code.

https://codereview.webrtc.org/2996933003/diff/180001/webrtc/rtc_base/asyncres...
File webrtc/rtc_base/asyncresolverinterface.h (right):

https://codereview.webrtc.org/2996933003/diff/180001/webrtc/rtc_base/asyncres...
webrtc/rtc_base/asyncresolverinterface.h:40: // Return resolve elapsed time in
milliseconds.
nit: This comment is mostly redundant given the name of the method; I'd expand
on it or just remove it.

https://codereview.webrtc.org/2996933003/diff/180001/webrtc/rtc_base/nethelpe...
File webrtc/rtc_base/nethelpers.h (right):

https://codereview.webrtc.org/2996933003/diff/180001/webrtc/rtc_base/nethelpe...
webrtc/rtc_base/nethelpers.h:56: int64_t resolve_time_ms_;
Initialize to 0 here?

[jonaso, 2017-08-29 07:22:32]

The CQ bit was checked by jonaso@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-29 07:22:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-29 07:56:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-29 07:56:13]

Dry run: This issue passed the CQ dry run.

[jonaso1, 2017-08-29 10:14:37]

Description was changed from

==========
Add logging host lookups made by TurnPort to the RtcEventLog.

The following fields are logged:
- hostname, that is being looked up.
- error, if there was an error.
- resulting IP (if a entry found)
- elapsed time in microseconds.

BUG=webrtc:8100
==========

to

==========
Add logging host lookups made by TurnPort to the RtcEventLog.

The following fields are logged:
- error, if there was an error.
- elapsed time in milliseconds

BUG=webrtc:8100
==========

[jonaso1, 2017-08-29 10:18:28]

thx for comments.
submitting

https://codereview.webrtc.org/2996933003/diff/180001/webrtc/logging/rtc_event...
File webrtc/logging/rtc_event_log/rtc_event_log.h (right):

https://codereview.webrtc.org/2996933003/diff/180001/webrtc/logging/rtc_event...
webrtc/logging/rtc_event_log/rtc_event_log.h:174: virtual void
LogHostLookupResult(int error,
On 2017/08/29 02:30:56, Taylor Brandstetter wrote:
> Can this comment document what "error" is? It looks like it's 0 on success, -1
> on generic failure or "no address available for desired address family", and
> otherwise is a "getaddrinfo" error code.

Done.

https://codereview.webrtc.org/2996933003/diff/180001/webrtc/rtc_base/asyncres...
File webrtc/rtc_base/asyncresolverinterface.h (right):

https://codereview.webrtc.org/2996933003/diff/180001/webrtc/rtc_base/asyncres...
webrtc/rtc_base/asyncresolverinterface.h:40: // Return resolve elapsed time in
milliseconds.
On 2017/08/29 02:30:56, Taylor Brandstetter wrote:
> nit: This comment is mostly redundant given the name of the method; I'd expand
> on it or just remove it.

Done.

https://codereview.webrtc.org/2996933003/diff/180001/webrtc/rtc_base/nethelpe...
File webrtc/rtc_base/nethelpers.h (right):

https://codereview.webrtc.org/2996933003/diff/180001/webrtc/rtc_base/nethelpe...
webrtc/rtc_base/nethelpers.h:56: int64_t resolve_time_ms_;
On 2017/08/29 02:30:56, Taylor Brandstetter wrote:
> Initialize to 0 here?

Done.

[jonaso1, 2017-08-29 10:18:44]

The CQ bit was checked by jonaso@google.com

[jonaso1, 2017-08-29 10:18:45]

The patchset sent to the CQ was uploaded after l-g-t-m from jonaso@google.com,
terelius@webrtc.org, deadbeef@webrtc.org, solenberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2996933003/#ps200001 (title:
"review")

[commit-bot: I haz the power, 2017-08-29 10:18:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-29 10:20:59]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1504001924763700,
"parent_rev": "f83dc8bbe587442b33e322ff076933358f1a6f47", "commit_rev":
"c251cb13c08aba710ba3a12588beb4aa172c7323"}

[commit-bot: I haz the power, 2017-08-29 10:21:04]

Description was changed from

==========
Add logging host lookups made by TurnPort to the RtcEventLog.

The following fields are logged:
- error, if there was an error.
- elapsed time in milliseconds

BUG=webrtc:8100
==========

to

==========
Add logging host lookups made by TurnPort to the RtcEventLog.

The following fields are logged:
- error, if there was an error.
- elapsed time in milliseconds

BUG=webrtc:8100

Review-Url: https://codereview.webrtc.org/2996933003
Cr-Commit-Position: refs/heads/master@{#19574}
Committed:
https://chromium.googlesource.com/external/webrtc/+/c251cb13c08aba710ba3a1258...
==========

[commit-bot: I haz the power, 2017-08-29 10:21:06]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/external/webrtc/+/c251cb13c08aba710ba3a1258...

[Max Morin WebRTC, 2017-08-29 11:48:40]

A revert of this CL (patchset #11 id:200001) has been created in
https://codereview.webrtc.org/3012473002/ by maxmorin@webrtc.org.

The reason for reverting is: Breaks Chromium build due to the changed
constructor in webrtc/p2p/client/basicportallocator.h.

Build (example):
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui....

Log:
FAILED: obj/remoting/protocol/protocol/port_allocator.o 
/b/c/goma_client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++
-MMD -MF obj/remoting/protocol/protocol/port_allocator.o.d
-DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1
-DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING
-DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD
-DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"310694-2\"
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCOMPONENT_BUILD -D_DEBUG
-DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1
-D_GLIBCXX_DEBUG=1 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32
-DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DEXPAT_RELATIVE_PATH
-DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DGOOGLE_PROTOBUF_NO_RTTI
-DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DPROTOBUF_USE_DLLS
-DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DFEATURE_ENABLE_VOICEMAIL
-DGTEST_RELATIVE_PATH -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX
-DBORINGSSL_SHARED_LIBRARY -I../.. -Igen
-I../../build/linux/debian_jessie_amd64-sysroot/usr/include/glib-2.0
-I../../build/linux/debian_jessie_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include
-I../../third_party/libwebp/src -I../../third_party/khronos -I../../gpu
-I../../third_party/protobuf/src -Igen/protoc_out
-I../../third_party/protobuf/src -I../../third_party/webrtc_overrides
-I../../testing/gtest/include -I../../third_party
-I../../third_party/webrtc_overrides -I../../third_party
-I../../third_party/boringssl/src/include
-I../../build/linux/debian_jessie_amd64-sysroot/usr/include/nss
-I../../build/linux/debian_jessie_amd64-sysroot/usr/include/nspr
-I../../third_party/libyuv/include -fno-strict-aliasing
--param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined
-D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe
-B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics
-fdebug-prefix-map=/b/c/b/Linux_Builder__dbg_/src=. -m64 -march=x86-64 -Wall
-Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter
-Wno-c++11-narrowing -Wno-covered-switch-default
-Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override
-Wno-undefined-var-template -Wno-nonportable-include-path
-Wno-address-of-packed-member -Wno-unused-lambda-capture
-Wno-user-defined-warnings -Wno-enum-compare-switch -O0 -fno-omit-frame-pointer
-g2 -gsplit-dwarf -fvisibility=hidden -Xclang -load -Xclang
../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang
-add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs
-Xclang check-auto-raw-pointer -Xclang -plugin-arg-find-bad-constructs -Xclang
check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare
-Wexit-time-destructors -Wno-header-guard -Wno-undefined-bool-conversion
-Wno-tautological-undefined-compare -std=gnu++14 -fno-rtti -nostdinc++
-isystem../../buildtools/third_party/libc++/trunk/include
-isystem../../buildtools/third_party/libc++abi/trunk/include
--sysroot=../../build/linux/debian_jessie_amd64-sysroot -fno-exceptions
-fvisibility-inlines-hidden -c ../../remoting/protocol/port_allocator.cc -o
obj/remoting/protocol/protocol/port_allocator.o
../../remoting/protocol/port_allocator.cc:48:7: error: no matching constructor
for initialization of 'cricket::BasicPortAllocator'
    : BasicPortAllocator(network_manager.get(), socket_factory.get()),
      ^                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/webrtc/p2p/client/basicportallocator.h:35:12: note: candidate
constructor not viable: requires single argument 'network_manager', but 2
arguments were provided
  explicit BasicPortAllocator(rtc::NetworkManager* network_manager);
           ^
../../third_party/webrtc/p2p/client/basicportallocator.h:30:7: note: candidate
constructor (the implicit copy constructor) not viable: requires 1 argument, but
2 were provided
class BasicPortAllocator : public PortAllocator {
      ^
../../third_party/webrtc/p2p/client/basicportallocator.h:32:3: note: candidate
constructor not viable: requires 3 arguments, but 2 were provided
  BasicPortAllocator(rtc::NetworkManager* network_manager,
  ^
../../third_party/webrtc/p2p/client/basicportallocator.h:36:3: note: candidate
constructor not viable: requires 3 arguments, but 2 were provided
  BasicPortAllocator(rtc::NetworkManager* network_manager,
  ^
../../third_party/webrtc/p2p/client/basicportallocator.h:39:3: note: candidate
constructor not viable: requires 5 arguments, but 2 were provided
  BasicPortAllocator(rtc::NetworkManager* network_manager,
  ^
1 error generated..