Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: webrtc/logging/rtc_event_log/rtc_event_log.proto

Issue 2996933003: Add logging of host lookups made by TurnPort to the RtcEventLog. (Closed)
Patch Set: review - remove strings from proto Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 syntax = "proto2"; 1 syntax = "proto2";
2 option optimize_for = LITE_RUNTIME; 2 option optimize_for = LITE_RUNTIME;
3 package webrtc.rtclog; 3 package webrtc.rtclog;
4 4
5 enum MediaType { 5 enum MediaType {
6 ANY = 0; 6 ANY = 0;
7 AUDIO = 1; 7 AUDIO = 1;
8 VIDEO = 2; 8 VIDEO = 2;
9 DATA = 3; 9 DATA = 3;
10 } 10 }
(...skipping 22 matching lines...) Expand all
33 AUDIO_PLAYOUT_EVENT = 5; 33 AUDIO_PLAYOUT_EVENT = 5;
34 LOSS_BASED_BWE_UPDATE = 6; 34 LOSS_BASED_BWE_UPDATE = 6;
35 DELAY_BASED_BWE_UPDATE = 7; 35 DELAY_BASED_BWE_UPDATE = 7;
36 VIDEO_RECEIVER_CONFIG_EVENT = 8; 36 VIDEO_RECEIVER_CONFIG_EVENT = 8;
37 VIDEO_SENDER_CONFIG_EVENT = 9; 37 VIDEO_SENDER_CONFIG_EVENT = 9;
38 AUDIO_RECEIVER_CONFIG_EVENT = 10; 38 AUDIO_RECEIVER_CONFIG_EVENT = 10;
39 AUDIO_SENDER_CONFIG_EVENT = 11; 39 AUDIO_SENDER_CONFIG_EVENT = 11;
40 AUDIO_NETWORK_ADAPTATION_EVENT = 16; 40 AUDIO_NETWORK_ADAPTATION_EVENT = 16;
41 BWE_PROBE_CLUSTER_CREATED_EVENT = 17; 41 BWE_PROBE_CLUSTER_CREATED_EVENT = 17;
42 BWE_PROBE_RESULT_EVENT = 18; 42 BWE_PROBE_RESULT_EVENT = 18;
43 HOST_LOOKUP_EVENT = 19;
43 } 44 }
44 45
45 // required - Indicates the type of this event 46 // required - Indicates the type of this event
46 optional EventType type = 2; 47 optional EventType type = 2;
47 48
48 oneof subtype { 49 oneof subtype {
49 // required if type == RTP_EVENT 50 // required if type == RTP_EVENT
50 RtpPacket rtp_packet = 3; 51 RtpPacket rtp_packet = 3;
51 52
52 // required if type == RTCP_EVENT 53 // required if type == RTCP_EVENT
(...skipping 21 matching lines...) Expand all
74 AudioSendConfig audio_sender_config = 11; 75 AudioSendConfig audio_sender_config = 11;
75 76
76 // required if type == AUDIO_NETWORK_ADAPTATION_EVENT 77 // required if type == AUDIO_NETWORK_ADAPTATION_EVENT
77 AudioNetworkAdaptation audio_network_adaptation = 16; 78 AudioNetworkAdaptation audio_network_adaptation = 16;
78 79
79 // required if type == BWE_PROBE_CLUSTER_CREATED_EVENT 80 // required if type == BWE_PROBE_CLUSTER_CREATED_EVENT
80 BweProbeCluster probe_cluster = 17; 81 BweProbeCluster probe_cluster = 17;
81 82
82 // required if type == BWE_PROBE_RESULT_EVENT 83 // required if type == BWE_PROBE_RESULT_EVENT
83 BweProbeResult probe_result = 18; 84 BweProbeResult probe_result = 18;
85
86 // required if type == HOST_LOOKUP_EVENT
87 HostLookupResult host_lookup_result = 19;
84 } 88 }
85 } 89 }
86 90
87 message RtpPacket { 91 message RtpPacket {
88 // required - True if the packet is incoming w.r.t. the user logging the data 92 // required - True if the packet is incoming w.r.t. the user logging the data
89 optional bool incoming = 1; 93 optional bool incoming = 1;
90 94
91 optional MediaType type = 2 [deprecated = true]; 95 optional MediaType type = 2 [deprecated = true];
92 96
93 // required - The size of the packet including both payload and header. 97 // required - The size of the packet including both payload and header.
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
307 INVALID_SEND_RECEIVE_RATIO = 2; 311 INVALID_SEND_RECEIVE_RATIO = 2;
308 TIMEOUT = 3; 312 TIMEOUT = 3;
309 } 313 }
310 314
311 // required - The result of this probing attempt. 315 // required - The result of this probing attempt.
312 optional ResultType result = 2; 316 optional ResultType result = 2;
313 317
314 // optional - but required if result == SUCCESS. The resulting bitrate in bps. 318 // optional - but required if result == SUCCESS. The resulting bitrate in bps.
315 optional uint64 bitrate_bps = 3; 319 optional uint64 bitrate_bps = 3;
316 } 320 }
321
322 message HostLookupResult {
323 // required - error code or 0 for OK
324 optional int32 error = 1;
325
326 // required - Time elapsed for lookup.
327 optional int64 elapsed_time_in_milliseconds = 2;
terelius 2017/08/18 11:41:33 I'd prefer elapsed_time_ms or (maybe even better)
328 }
329
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698