Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: webrtc/logging/rtc_event_log/rtc_event_log.proto

Issue 2996933003: Add logging of host lookups made by TurnPort to the RtcEventLog. (Closed)
Patch Set: review - remove strings from proto Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/logging/rtc_event_log/rtc_event_log.proto
diff --git a/webrtc/logging/rtc_event_log/rtc_event_log.proto b/webrtc/logging/rtc_event_log/rtc_event_log.proto
index b9053ae87dabd5082587226c396cfed09825a06a..63893b3640b0f6a5373923516a08530c9c01d897 100644
--- a/webrtc/logging/rtc_event_log/rtc_event_log.proto
+++ b/webrtc/logging/rtc_event_log/rtc_event_log.proto
@@ -40,6 +40,7 @@ message Event {
AUDIO_NETWORK_ADAPTATION_EVENT = 16;
BWE_PROBE_CLUSTER_CREATED_EVENT = 17;
BWE_PROBE_RESULT_EVENT = 18;
+ HOST_LOOKUP_EVENT = 19;
}
// required - Indicates the type of this event
@@ -81,6 +82,9 @@ message Event {
// required if type == BWE_PROBE_RESULT_EVENT
BweProbeResult probe_result = 18;
+
+ // required if type == HOST_LOOKUP_EVENT
+ HostLookupResult host_lookup_result = 19;
}
}
@@ -314,3 +318,12 @@ message BweProbeResult {
// optional - but required if result == SUCCESS. The resulting bitrate in bps.
optional uint64 bitrate_bps = 3;
}
+
+message HostLookupResult {
+ // required - error code or 0 for OK
+ optional int32 error = 1;
+
+ // required - Time elapsed for lookup.
+ optional int64 elapsed_time_in_milliseconds = 2;
terelius 2017/08/18 11:41:33 I'd prefer elapsed_time_ms or (maybe even better)
+}
+

Powered by Google App Engine
This is Rietveld 408576698