Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Side by Side Diff: webrtc/logging/rtc_event_log/rtc_event_log.h

Issue 2996933003: Add logging of host lookups made by TurnPort to the RtcEventLog. (Closed)
Patch Set: review Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 int min_probes, 163 int min_probes,
164 int min_bytes) = 0; 164 int min_bytes) = 0;
165 165
166 // Logs the result of a successful probing attempt. 166 // Logs the result of a successful probing attempt.
167 virtual void LogProbeResultSuccess(int id, int bitrate_bps) = 0; 167 virtual void LogProbeResultSuccess(int id, int bitrate_bps) = 0;
168 168
169 // Logs the result of an unsuccessful probing attempt. 169 // Logs the result of an unsuccessful probing attempt.
170 virtual void LogProbeResultFailure(int id, 170 virtual void LogProbeResultFailure(int id,
171 ProbeFailureReason failure_reason) = 0; 171 ProbeFailureReason failure_reason) = 0;
172 172
173 // Logs the result of a host lookup.
174 virtual void LogHostLookupResult(int error,
Taylor Brandstetter 2017/08/29 02:30:56 Can this comment document what "error" is? It look
jonaso1 2017/08/29 10:18:28 Done.
175 int64_t elapsed_time_in_milliseconds) = 0;
176
173 // Reads an RtcEventLog file and returns true when reading was successful. 177 // Reads an RtcEventLog file and returns true when reading was successful.
174 // The result is stored in the given EventStream object. 178 // The result is stored in the given EventStream object.
175 // The order of the events in the EventStream is implementation defined. 179 // The order of the events in the EventStream is implementation defined.
176 // The current implementation writes a LOG_START event, then the old 180 // The current implementation writes a LOG_START event, then the old
177 // configurations, then the remaining events in timestamp order and finally 181 // configurations, then the remaining events in timestamp order and finally
178 // a LOG_END event. However, this might change without further notice. 182 // a LOG_END event. However, this might change without further notice.
179 // TODO(terelius): Change result type to a vector? 183 // TODO(terelius): Change result type to a vector?
180 static bool ParseRtcEventLog(const std::string& file_name, 184 static bool ParseRtcEventLog(const std::string& file_name,
181 rtclog::EventStream* result); 185 rtclog::EventStream* result);
182 }; 186 };
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 BandwidthUsage detector_state) override {} 221 BandwidthUsage detector_state) override {}
218 void LogAudioNetworkAdaptation( 222 void LogAudioNetworkAdaptation(
219 const AudioEncoderRuntimeConfig& config) override {} 223 const AudioEncoderRuntimeConfig& config) override {}
220 void LogProbeClusterCreated(int id, 224 void LogProbeClusterCreated(int id,
221 int bitrate_bps, 225 int bitrate_bps,
222 int min_probes, 226 int min_probes,
223 int min_bytes) override{}; 227 int min_bytes) override{};
224 void LogProbeResultSuccess(int id, int bitrate_bps) override{}; 228 void LogProbeResultSuccess(int id, int bitrate_bps) override{};
225 void LogProbeResultFailure(int id, 229 void LogProbeResultFailure(int id,
226 ProbeFailureReason failure_reason) override{}; 230 ProbeFailureReason failure_reason) override{};
231
232 void LogHostLookupResult(int error,
233 int64_t elapsed_time_in_milliseconds) override {}
227 }; 234 };
228 235
229 } // namespace webrtc 236 } // namespace webrtc
230 237
231 #endif // WEBRTC_LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_H_ 238 #endif // WEBRTC_LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698