Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: webrtc/logging/rtc_event_log/rtc_event_log.h

Issue 2996933003: Add logging of host lookups made by TurnPort to the RtcEventLog. (Closed)
Patch Set: review Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/logging/rtc_event_log/rtc_event_log.h
diff --git a/webrtc/logging/rtc_event_log/rtc_event_log.h b/webrtc/logging/rtc_event_log/rtc_event_log.h
index dc3351120c89d458222e715ad0a872f5804dc2c7..4b7de54125ec804c863d836e2cbc8117bd3b0c0a 100644
--- a/webrtc/logging/rtc_event_log/rtc_event_log.h
+++ b/webrtc/logging/rtc_event_log/rtc_event_log.h
@@ -170,6 +170,10 @@ class RtcEventLog {
virtual void LogProbeResultFailure(int id,
ProbeFailureReason failure_reason) = 0;
+ // Logs the result of a host lookup.
+ virtual void LogHostLookupResult(int error,
Taylor Brandstetter 2017/08/29 02:30:56 Can this comment document what "error" is? It look
jonaso1 2017/08/29 10:18:28 Done.
+ int64_t elapsed_time_in_milliseconds) = 0;
+
// Reads an RtcEventLog file and returns true when reading was successful.
// The result is stored in the given EventStream object.
// The order of the events in the EventStream is implementation defined.
@@ -224,6 +228,9 @@ class RtcEventLogNullImpl : public RtcEventLog {
void LogProbeResultSuccess(int id, int bitrate_bps) override{};
void LogProbeResultFailure(int id,
ProbeFailureReason failure_reason) override{};
+
+ void LogHostLookupResult(int error,
+ int64_t elapsed_time_in_milliseconds) override {}
};
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698