Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 syntax = "proto2"; | 1 syntax = "proto2"; |
| 2 option optimize_for = LITE_RUNTIME; | 2 option optimize_for = LITE_RUNTIME; |
| 3 package webrtc.rtclog; | 3 package webrtc.rtclog; |
| 4 | 4 |
| 5 enum MediaType { | 5 enum MediaType { |
| 6 ANY = 0; | 6 ANY = 0; |
| 7 AUDIO = 1; | 7 AUDIO = 1; |
| 8 VIDEO = 2; | 8 VIDEO = 2; |
| 9 DATA = 3; | 9 DATA = 3; |
| 10 } | 10 } |
| (...skipping 22 matching lines...) Expand all Loading... | |
| 33 AUDIO_PLAYOUT_EVENT = 5; | 33 AUDIO_PLAYOUT_EVENT = 5; |
| 34 LOSS_BASED_BWE_UPDATE = 6; | 34 LOSS_BASED_BWE_UPDATE = 6; |
| 35 DELAY_BASED_BWE_UPDATE = 7; | 35 DELAY_BASED_BWE_UPDATE = 7; |
| 36 VIDEO_RECEIVER_CONFIG_EVENT = 8; | 36 VIDEO_RECEIVER_CONFIG_EVENT = 8; |
| 37 VIDEO_SENDER_CONFIG_EVENT = 9; | 37 VIDEO_SENDER_CONFIG_EVENT = 9; |
| 38 AUDIO_RECEIVER_CONFIG_EVENT = 10; | 38 AUDIO_RECEIVER_CONFIG_EVENT = 10; |
| 39 AUDIO_SENDER_CONFIG_EVENT = 11; | 39 AUDIO_SENDER_CONFIG_EVENT = 11; |
| 40 AUDIO_NETWORK_ADAPTATION_EVENT = 16; | 40 AUDIO_NETWORK_ADAPTATION_EVENT = 16; |
| 41 BWE_PROBE_CLUSTER_CREATED_EVENT = 17; | 41 BWE_PROBE_CLUSTER_CREATED_EVENT = 17; |
| 42 BWE_PROBE_RESULT_EVENT = 18; | 42 BWE_PROBE_RESULT_EVENT = 18; |
| 43 HOST_LOOKUP_EVENT = 19; | |
| 43 } | 44 } |
| 44 | 45 |
| 45 // required - Indicates the type of this event | 46 // required - Indicates the type of this event |
| 46 optional EventType type = 2; | 47 optional EventType type = 2; |
| 47 | 48 |
| 48 oneof subtype { | 49 oneof subtype { |
| 49 // required if type == RTP_EVENT | 50 // required if type == RTP_EVENT |
| 50 RtpPacket rtp_packet = 3; | 51 RtpPacket rtp_packet = 3; |
| 51 | 52 |
| 52 // required if type == RTCP_EVENT | 53 // required if type == RTCP_EVENT |
| (...skipping 21 matching lines...) Expand all Loading... | |
| 74 AudioSendConfig audio_sender_config = 11; | 75 AudioSendConfig audio_sender_config = 11; |
| 75 | 76 |
| 76 // required if type == AUDIO_NETWORK_ADAPTATION_EVENT | 77 // required if type == AUDIO_NETWORK_ADAPTATION_EVENT |
| 77 AudioNetworkAdaptation audio_network_adaptation = 16; | 78 AudioNetworkAdaptation audio_network_adaptation = 16; |
| 78 | 79 |
| 79 // required if type == BWE_PROBE_CLUSTER_CREATED_EVENT | 80 // required if type == BWE_PROBE_CLUSTER_CREATED_EVENT |
| 80 BweProbeCluster probe_cluster = 17; | 81 BweProbeCluster probe_cluster = 17; |
| 81 | 82 |
| 82 // required if type == BWE_PROBE_RESULT_EVENT | 83 // required if type == BWE_PROBE_RESULT_EVENT |
| 83 BweProbeResult probe_result = 18; | 84 BweProbeResult probe_result = 18; |
| 85 | |
| 86 // required if type == HOST_LOOKUP_EVENT | |
| 87 HostLookupResult host_lookup_result = 19; | |
| 84 } | 88 } |
| 85 } | 89 } |
| 86 | 90 |
| 87 message RtpPacket { | 91 message RtpPacket { |
| 88 // required - True if the packet is incoming w.r.t. the user logging the data | 92 // required - True if the packet is incoming w.r.t. the user logging the data |
| 89 optional bool incoming = 1; | 93 optional bool incoming = 1; |
| 90 | 94 |
| 91 optional MediaType type = 2 [deprecated = true]; | 95 optional MediaType type = 2 [deprecated = true]; |
| 92 | 96 |
| 93 // required - The size of the packet including both payload and header. | 97 // required - The size of the packet including both payload and header. |
| (...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 307 INVALID_SEND_RECEIVE_RATIO = 2; | 311 INVALID_SEND_RECEIVE_RATIO = 2; |
| 308 TIMEOUT = 3; | 312 TIMEOUT = 3; |
| 309 } | 313 } |
| 310 | 314 |
| 311 // required - The result of this probing attempt. | 315 // required - The result of this probing attempt. |
| 312 optional ResultType result = 2; | 316 optional ResultType result = 2; |
| 313 | 317 |
| 314 // optional - but required if result == SUCCESS. The resulting bitrate in bps. | 318 // optional - but required if result == SUCCESS. The resulting bitrate in bps. |
| 315 optional uint64 bitrate_bps = 3; | 319 optional uint64 bitrate_bps = 3; |
| 316 } | 320 } |
| 321 | |
| 322 message HostLookupResult { | |
| 323 // optional - hostname. | |
| 324 optional string hostname = 1; | |
|
terelius
2017/08/16 14:19:06
Generally speaking, we don't want to have strings
| |
| 325 | |
| 326 // required - error code. | |
| 327 optional int32 error = 2; | |
| 328 | |
| 329 // optional - resulting IP address (anonymized). | |
| 330 optional string lookup_result = 3; | |
|
terelius
2017/08/16 14:19:07
Same here. How do we guarantee anonymization?
| |
| 331 | |
| 332 // required - Time elapsed for lookup. | |
| 333 optional int64 elapsed_time_in_microseconds = 4; | |
|
terelius
2017/08/16 14:19:06
Is microsecond accuracy needed here?
| |
| 334 } | |
| 335 | |
| OLD | NEW |