Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc

Issue 2996933003: Add logging of host lookups made by TurnPort to the RtcEventLog. (Closed)
Patch Set: review - remove strings from proto Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 552 matching lines...) Expand 10 before | Expand all | Expand 10 after
563 const rtclog::BweProbeResult& bwe_event = event.probe_result(); 563 const rtclog::BweProbeResult& bwe_event = event.probe_result();
564 ASSERT_TRUE(bwe_event.has_id()); 564 ASSERT_TRUE(bwe_event.has_id());
565 EXPECT_EQ(id, bwe_event.id()); 565 EXPECT_EQ(id, bwe_event.id());
566 ASSERT_TRUE(bwe_event.has_result()); 566 ASSERT_TRUE(bwe_event.has_result());
567 EXPECT_EQ(GetProbeResultType(failure_reason), bwe_event.result()); 567 EXPECT_EQ(GetProbeResultType(failure_reason), bwe_event.result());
568 ASSERT_FALSE(bwe_event.has_bitrate_bps()); 568 ASSERT_FALSE(bwe_event.has_bitrate_bps());
569 569
570 // TODO(philipel): Verify the parser when parsing has been implemented. 570 // TODO(philipel): Verify the parser when parsing has been implemented.
571 } 571 }
572 572
573 void RtcEventLogTestHelper::VerifyLogHostLookupEvent(
terelius 2017/08/18 11:41:33 You should also test that the error code and elaps
574 const ParsedRtcEventLog& parsed_log,
575 size_t index) {
576 const rtclog::Event& event = parsed_log.events_[index];
577 ASSERT_TRUE(IsValidBasicEvent(event));
578 EXPECT_EQ(rtclog::Event::HOST_LOOKUP_EVENT, event.type());
579 }
580
573 } // namespace webrtc 581 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698