Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2909613002: Replaced usage of RefPtr::Release with std::move wraps. (Closed)

Created:
3 years, 7 months ago by Bugs Nash
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, shans, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, leviw+bidiwatch_chromium.org, dcheng, apavlov+blink_chromium.org, kinuko+worker_chromium.org, kinuko+watch, rwlbuis, krit, drott+blinkwatch_chromium.org, awdf+watch_chromium.org, Nate Chapin, yhirano+watch_chromium.org, blink-reviews-css, Justin Novosad, hongchan, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, gavinp+loader_chromium.org, Navid Zolghadr, blink-reviews, falken+watch_chromium.org, blink-worker-reviews_chromium.org, Eric Willigers, rjwright, blink-reviews-style_chromium.org, Peter Beverloo, sof, Raymond Toy, loading-reviews_chromium.org, pdr+graphicswatchlist_chromium.org, darktears, haraken, loading-reviews+fetch_chromium.org, jsbell+idb_chromium.org, Stephen Chennney, tyoshino+watch_chromium.org, dtapuska+blinkwatch_chromium.org, mlamouri+watch-blink_chromium.org, blink-reviews-animation_chromium.org, fmalita+watch_chromium.org, shimazu+worker_chromium.org, cmumford, horo+watch_chromium.org, blink-reviews-frames_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replaced usage of RefPtr::Release with std::move wraps. Replaces many of the calls to RefPtr::Release with a std::move wrap, which returns a RefPtr instead of a PassRefPtr. As the code currently stands, most methods still expect a PassRefPtr and so the PassRefPtr initialising constructor will be called passing in the RefPtr rvalue, which calls RefPtr::Release anyway. Future patches will see these variables changed from PassRefPtr to RefPtr type then RefPtr::Release will not be used at all. Does not handle RefPtr::Release calls in return statements that default to move. This will be handled in a future patch. NB patch also added new braces to if statements to satisfy presubmit errors. BUG=494719 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -51 lines) Patch
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMTypedArray.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/SuspendableScriptExecutor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/WebFrameWidgetBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/RequestInit.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBCursor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNode.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioWorkletThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/GLStringQuery.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/BidiResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/text/WTFString.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/typed_arrays/TypedArrayBase.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (4 generated)
Bugs Nash
Description was changed from ========== Replaced usage of RefPtr::Release with std::move wraps. Replaces many of ...
3 years, 7 months ago (2017-05-26 03:34:49 UTC) #1
Bugs Nash
The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-26 03:34:56 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909613002/1
3 years, 7 months ago (2017-05-26 03:35:49 UTC) #3
Bugs Nash
3 years, 7 months ago (2017-05-26 03:43:47 UTC) #4
The CQ bit was unchecked by bugsnash@chromium.org

Powered by Google App Engine
This is Rietveld 408576698