third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp - Issue 2909613002: Replaced usage of RefPtr::Release with std::move wraps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp

Issue 2909613002: Replaced usage of RefPtr::Release with std::move wraps. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp

diff --git a/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp b/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp

index 315fec915f506d674d1ae955cff69d4136a8b84f..1988352508ec3d572ba34bca09fc3aecd1601420 100644

--- a/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp

+++ b/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp

@@ -715,7 +715,7 @@ void DOMWebSocket::DidReceiveBinaryMessage(

RefPtr<RawData> raw_data = RawData::Create();

binary_data->swap(*raw_data->MutableData());

std::unique_ptr<BlobData> blob_data = BlobData::Create();

- blob_data->AppendData(raw_data.Release(), 0, BlobDataItem::kToEndOfFile);

+ blob_data->AppendData(std::move(raw_data), 0, BlobDataItem::kToEndOfFile);

Blob* blob =

Blob::Create(BlobDataHandle::Create(std::move(blob_data), size));

RecordReceiveTypeHistogram(kWebSocketReceiveTypeBlob);