third_party/WebKit/Source/core/frame/SuspendableScriptExecutor.cpp - Issue 2909613002: Replaced usage of RefPtr::Release with std::move wraps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/SuspendableScriptExecutor.cpp

Issue 2909613002: Replaced usage of RefPtr::Release with std::move wraps. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/SuspendableScriptExecutor.cpp

diff --git a/third_party/WebKit/Source/core/frame/SuspendableScriptExecutor.cpp b/third_party/WebKit/Source/core/frame/SuspendableScriptExecutor.cpp

index 4d8de1121c562fe4cd0f71e4238b6e27587a48c3..e9c9474c9b2f12d2203db26cfbc6954311032ec3 100644

--- a/third_party/WebKit/Source/core/frame/SuspendableScriptExecutor.cpp

+++ b/third_party/WebKit/Source/core/frame/SuspendableScriptExecutor.cpp

@@ -114,7 +114,7 @@ Vector<v8::Local<v8::Value>> V8FunctionExecutor::Execute(LocalFrame* frame) {

std::unique_ptr<UserGestureIndicator> gesture_indicator;

if (gesture_token_) {

gesture_indicator =

- WTF::WrapUnique(new UserGestureIndicator(gesture_token_.Release()));

+ WTF::WrapUnique(new UserGestureIndicator(std::move(gesture_token_)));

}

if (V8ScriptRunner::CallFunction(function_.NewLocal(isolate),

frame->GetDocument(),