third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp - Issue 2909613002: Replaced usage of RefPtr::Release with std::move wraps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

Issue 2909613002: Replaced usage of RefPtr::Release with std::move wraps. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp ('k') | third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp b/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

index c8cdd80d54ec9cc20e0e1125343a1133dd5bd41c..cd24f367518f57aa8fb1a38d13a686b23650bf72 100644

--- a/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

+++ b/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

@@ -174,7 +174,7 @@ void ServiceWorkerRegistrationNotifications::PrepareShow(

RefPtr<SecurityOrigin> origin = GetExecutionContext()->GetSecurityOrigin();

NotificationResourcesLoader* loader = new NotificationResourcesLoader(

WTF::Bind(&ServiceWorkerRegistrationNotifications::DidLoadResources,

- WrapWeakPersistent(this), origin.Release(), data,

+ WrapWeakPersistent(this), std::move(origin), data,

WTF::Passed(std::move(callbacks))));

loaders_.insert(loader);

loader->Start(GetExecutionContext(), data);