third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp - Issue 2909613002: Replaced usage of RefPtr::Release with std::move wraps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp

Issue 2909613002: Replaced usage of RefPtr::Release with std::move wraps. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp b/third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp

index 190e104f82b0fa03b654abd3ebcbbf5e342650b3..5fdf1564e7e8d97a7e632f5d9e159f4756806a15 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp

@@ -144,7 +144,7 @@ DOMFloat32Array* AudioBuffer::CreateFloat32ArrayOrNull(size_t length) {

WTF::Float32Array::CreateOrNull(length);

if (!buffer_view)

return nullptr;

- return DOMFloat32Array::Create(buffer_view.Release());

+ return DOMFloat32Array::Create(std::move(buffer_view));

}

AudioBuffer::AudioBuffer(unsigned number_of_channels,