Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2377303002: Revert of Fix race / crash in OnNetworkRouteChanged(). (Closed)

Created:
4 years, 2 months ago by stefan-webrtc
Modified:
4 years, 2 months ago
Reviewers:
terelius
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, perkj_webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Fix race / crash in OnNetworkRouteChanged(). (patchset #5 id:80001 of https://codereview.webrtc.org/2366333003/ ) Reason for revert: Caused issues with webrtc_perf_tests on build bots. Original issue's description: > Fix race / crash in OnNetworkRouteChanged(). > > To achieve this some refactoring was done to make it possible to synchronize > access to the DelayBasedBwe in TransportFeedbackAdapter: > - The callback was removed from DelayBasedBwe, it now instead returns its > result. > - TransportFeedbackAdapter was moved to modules/congestion_controller to avoid > unnecessary dependencies. > > Reenables previously disabled flaky test. Can no longer reproduce flakiness with gtest-parallel and asan/tsan builds. > > BUG=webrtc:6427, webrtc:6422 > > Committed: https://crrev.com/fd0d42669204e6dd92a60736bca7ae0196663024 > Cr-Commit-Position: refs/heads/master@{#14430} TBR=terelius@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6427, webrtc:6422 Committed: https://crrev.com/5ec85fbcb7ef7ba0684ae2b69df7f36f118bb31f Cr-Commit-Position: refs/heads/master@{#14433}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+821 lines, -822 lines) Patch
M webrtc/modules/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.h View 1 chunk +4 lines, -1 line 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.cc View 1 chunk +16 lines, -12 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/bitrate_controller/include/bitrate_controller.h View 3 chunks +2 lines, -4 lines 0 comments Download
M webrtc/modules/congestion_controller/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 6 chunks +13 lines, -7 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe.h View 3 chunks +29 lines, -22 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe.cc View 7 chunks +93 lines, -80 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.h View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.cc View 14 chunks +59 lines, -57 lines 0 comments Download
M webrtc/modules/congestion_controller/include/congestion_controller.h View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/modules/congestion_controller/transport_feedback_adapter.h View 1 chunk +0 lines, -70 lines 0 comments Download
D webrtc/modules/congestion_controller/transport_feedback_adapter.cc View 1 chunk +0 lines, -158 lines 0 comments Download
D webrtc/modules/congestion_controller/transport_feedback_adapter_unittest.cc View 1 chunk +0 lines, -328 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.h View 1 chunk +65 lines, -0 lines 0 comments Download
A webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.cc View 1 chunk +148 lines, -0 lines 0 comments Download
A webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter_unittest.cc View 1 chunk +364 lines, -0 lines 0 comments Download
M webrtc/tools/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.cc View 3 chunks +1 line, -31 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 chunk +6 lines, -30 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
stefan-webrtc
Created Revert of Fix race / crash in OnNetworkRouteChanged().
4 years, 2 months ago (2016-09-29 11:19:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2377303002/1
4 years, 2 months ago (2016-09-29 11:19:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 11:19:41 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 11:19:49 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ec85fbcb7ef7ba0684ae2b69df7f36f118bb31f
Cr-Commit-Position: refs/heads/master@{#14433}

Powered by Google App Engine
This is Rietveld 408576698