Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: webrtc/tools/event_log_visualizer/analyzer.cc

Issue 2377303002: Revert of Fix race / crash in OnNetworkRouteChanged(). (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/tools/DEPS ('k') | webrtc/video/video_send_stream_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/tools/event_log_visualizer/analyzer.cc
diff --git a/webrtc/tools/event_log_visualizer/analyzer.cc b/webrtc/tools/event_log_visualizer/analyzer.cc
index d1dec22f0a1c2d0bd5462687ec6c51691f9fd537..260975b4b530f96bfff06f3f0b3eeff66e7e1526 100644
--- a/webrtc/tools/event_log_visualizer/analyzer.cc
+++ b/webrtc/tools/event_log_visualizer/analyzer.cc
@@ -24,7 +24,6 @@
#include "webrtc/base/rate_statistics.h"
#include "webrtc/call.h"
#include "webrtc/common_types.h"
-#include "webrtc/modules/bitrate_controller/include/bitrate_controller.h"
#include "webrtc/modules/congestion_controller/include/congestion_controller.h"
#include "webrtc/modules/rtp_rtcp/include/rtp_rtcp.h"
#include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"
@@ -1054,34 +1053,6 @@
plot->SetTitle("Simulated BWE behavior");
}
-// TODO(holmer): Remove once TransportFeedbackAdapter no longer needs a
-// BitrateController.
-class NullBitrateController : public BitrateController {
- public:
- ~NullBitrateController() override {}
- RtcpBandwidthObserver* CreateRtcpBandwidthObserver() override {
- return nullptr;
- }
- void SetStartBitrate(int start_bitrate_bps) override {}
- void SetMinMaxBitrate(int min_bitrate_bps, int max_bitrate_bps) override {}
- void SetBitrates(int start_bitrate_bps,
- int min_bitrate_bps,
- int max_bitrate_bps) override {}
- void ResetBitrates(int bitrate_bps,
- int min_bitrate_bps,
- int max_bitrate_bps) override {}
- void OnDelayBasedBweResult(const DelayBasedBwe::Result& result) override {}
- bool AvailableBandwidth(uint32_t* bandwidth) const override { return false; }
- void SetReservedBitrate(uint32_t reserved_bitrate_bps) override {}
- bool GetNetworkParameters(uint32_t* bitrate,
- uint8_t* fraction_loss,
- int64_t* rtt) override {
- return false;
- }
- int64_t TimeUntilNextProcess() override { return 0; }
- void Process() override {}
-};
-
void EventLogAnalyzer::CreateNetworkDelayFeedbackGraph(Plot* plot) {
std::map<uint64_t, const LoggedRtpPacket*> outgoing_rtp;
std::map<uint64_t, const LoggedRtcpPacket*> incoming_rtcp;
@@ -1102,8 +1073,7 @@
}
SimulatedClock clock(0);
- NullBitrateController null_controller;
- TransportFeedbackAdapter feedback_adapter(&clock, &null_controller);
+ TransportFeedbackAdapter feedback_adapter(&clock);
TimeSeries time_series;
time_series.label = "Network Delay Change";
« no previous file with comments | « webrtc/tools/DEPS ('k') | webrtc/video/video_send_stream_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698