Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: webrtc/video/video_send_stream_tests.cc

Issue 2377303002: Revert of Fix race / crash in OnNetworkRouteChanged(). (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/tools/event_log_visualizer/analyzer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/video_send_stream_tests.cc
diff --git a/webrtc/video/video_send_stream_tests.cc b/webrtc/video/video_send_stream_tests.cc
index 79b3e0483e243c171eba8c30321e8db4fbac60c0..a36be32d32834679aa9c12bb58327a6c4b8dae02 100644
--- a/webrtc/video/video_send_stream_tests.cc
+++ b/webrtc/video/video_send_stream_tests.cc
@@ -1135,42 +1135,18 @@
RunBaseTest(&test);
}
-TEST_F(VideoSendStreamTest, ChangingNetworkRoute) {
- static const int kStartBitrateBps = 300000;
- static const int kNewMaxBitrateBps = 1234567;
- static const uint8_t kExtensionId = 13;
+TEST_F(VideoSendStreamTest, DISABLED_ChangingNetworkRoute) {
class ChangingNetworkRouteTest : public test::EndToEndTest {
public:
+ const int kStartBitrateBps = 300000;
+ const int kNewMaxBitrateBps = 1234567;
+
ChangingNetworkRouteTest()
- : EndToEndTest(test::CallTest::kDefaultTimeoutMs), call_(nullptr) {
- EXPECT_TRUE(parser_->RegisterRtpHeaderExtension(
- kRtpExtensionTransportSequenceNumber, kExtensionId));
- }
+ : EndToEndTest(test::CallTest::kDefaultTimeoutMs),
+ call_(nullptr) {}
void OnCallsCreated(Call* sender_call, Call* receiver_call) override {
call_ = sender_call;
- }
-
- void ModifyVideoConfigs(
- VideoSendStream::Config* send_config,
- std::vector<VideoReceiveStream::Config>* receive_configs,
- VideoEncoderConfig* encoder_config) override {
- send_config->rtp.extensions.clear();
- send_config->rtp.extensions.push_back(RtpExtension(
- RtpExtension::kTransportSequenceNumberUri, kExtensionId));
- (*receive_configs)[0].rtp.extensions = send_config->rtp.extensions;
- (*receive_configs)[0].rtp.transport_cc = true;
- }
-
- void ModifyAudioConfigs(
- AudioSendStream::Config* send_config,
- std::vector<AudioReceiveStream::Config>* receive_configs) override {
- send_config->rtp.extensions.clear();
- send_config->rtp.extensions.push_back(RtpExtension(
- RtpExtension::kTransportSequenceNumberUri, kExtensionId));
- (*receive_configs)[0].rtp.extensions.clear();
- (*receive_configs)[0].rtp.extensions = send_config->rtp.extensions;
- (*receive_configs)[0].rtp.transport_cc = true;
}
Action OnSendRtp(const uint8_t* packet, size_t length) override {
« no previous file with comments | « webrtc/tools/event_log_visualizer/analyzer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698